[HOLD for payment 2022-05-20]Web - Log in - "Forgot?" password link is unresponsive

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging.new.expensify.com
2. Enter a email in the email field
3. Click on "Forgot?"

Expected Result:

User is notified that a magic link has been sent to their address

Actual Result:

"Forgot?" link is unresponsive. A js error in console is displayed. In the mobile apps, the app is crashing.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

This was introduced by one of the PRs recently added to the checklist. Possible culprits for the issue:

• show confirmation screen on password change #8493
• Fix bug where 2FA input field is permanently hidden after resetting password #8801

[thesahindia]

It's caused by #8801 as when 2FA isn't enabled the 2FA field doesn't get render so this.input2FA is undefined

I think we can just add a check here

App/src/pages/signin/PasswordForm.js

Lines 85 to 87 in ad3cbc9

	resetPassword() {
	this.setState({twoFactorAuthCode: ''}, this.input2FA.clear);
	Session.resetPassword();

        if (this.input2FA) {
            this.setState({twoFactorAuthCode: ''}, this.input2FA.clear);
        }

cc: @Julesssss

[Julesssss]

Nice find @thesahindia, let's get this opened up as an external issue.