Attachment - Download icon is not working in right side chat bar for mp4 and mov files

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue were found when executing PR: #8952

Action Performed:

1. Go https://staging.new.expensify.com/
2. Log in with any account
3. Find the chat where you can download the mp4 file
4. Hold the finger on file
5. Tap download

Expected Result:

Download icon is working in right side chat bar for mp4 and mov files

Actual Result:

Download icon is not working in right side chat bar for mp4 and mov filesd

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.60.0

Reproducible in staging?: Yes

Reproducible in production?: No (new feature)

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.404.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mvtglobally]

@thienlnam just saw your PR #8952. Can you confirm if this behavior is expected or no? and should we consider this Deploy blocker if its a bug?

[thienlnam]

cc @techievivek It seems as though this context menu doesn't work for movie files that got added in your PR

This is the console error, seems to be that the regex is not matching leading to an undefined error when looking for the URLs

@mvtglobally This behavior is unexpected, but it's a new feature that got added in the PR here. The download works if you click on the attachment and for other files. I think we are fine to not mark this as a deploy blocker since there are workarounds and uploading video files are not common

[joelbettner]

I'm going to un-assign myself. It sounds like @techievivek might know best how to fix this? But...perhaps @mvtglobally would be keen to get a fix out there. I'll let y'all sort that out.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.