[Due for payment 2026-06-09] iOS - Expense - Selection button is shown below the header in expense report in landscape mode

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.70-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87256
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.4.2
App Component: Money Requests

Action Performed:

1. Launch Expensify app.
2. Go to workspace chat.
3. Create two expenses.
4. Open the report.
5. Rotate the device to landscape.
6. Long tap on any expense > Select.

Expected Result:

Selection button will be displayed in the top-right corner as on desktop, not below the header.

Actual Result:

Selection button is shown below the header in expense report in landscape mode.

The same issue also happens on Spend tab.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7151376_1778545080129.ScreenRecording_05-12-2026_08-15-24_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @truph01

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #87256

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The selection mode early-return in MoneyReportHeader.tsx:100 checks isMobileSelectionModeEnabled && shouldUseNarrowLayout, but does not account for landscape mode. On native iOS, shouldUseNarrowLayout is always true, so this early-return always fires in selection mode — even in landscape — rendering a bare HeaderWithBackButton that bypasses the landscape-aware layout logic at line 81 (shouldShowHeaderButtonsInHeaderRow = isInLandscapeMode || ...).

The rest of the header correctly uses useShouldDisplayButtonsInSeparateLine which returns shouldUseNarrowLayout && !isInLandscapeMode, but the selection mode guard at line 100 doesn't apply the same !isInLandscapeMode exclusion.

What changes do you think we should make in order to solve the problem?

Add && !isInLandscapeMode to the selection mode condition at MoneyReportHeader.tsx:100, changing it from:

if (isMobileSelectionModeEnabled && shouldUseNarrowLayout)

to:

if (isMobileSelectionModeEnabled && shouldUseNarrowLayout && !isInLandscapeMode)

This way, in landscape mode the early-return is skipped and the normal header flow handles the layout — placing buttons inline in the header row via shouldShowHeaderButtonsInHeaderRow, consistent with how all other header buttons behave in landscape after PR #87256.

The same pattern should be checked in any other header components that handle selection mode (e.g., the Spend tab header) to ensure consistency.

What alternative solutions did you explore? (Optional)

An alternative would be to restructure the selection mode early-return to support both portrait and landscape layouts inline, but this adds unnecessary complexity. The simpler condition fix aligns with the existing pattern used by useShouldDisplayButtonsInSeparateLine.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.