Spend - IOU is displayed on "Top Spenders" section.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.70-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88752
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: User is owner of at least one track-intent workspace with at least one invited member.

1. Open the staging.new.expensify.com
2. Create a manual expense with date from last month and submit it to any individual chat.
3. Navigate to "Spend" > "Top Spenders"
4. Note that the just created expense is visible despite not being part of a workspace.

Expected Result:

Only expenses from workspaces with members should be visible on "Top Spenders" section.

Actual Result:

An expense submitted to an individual chat, can be found on "Top Spenders" section, despite not being part of a workspace.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #88752

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #88752 - "Resurface Top Spenders insight for track-intent workspace users" by @MelvinBot (High confidence)
Related Issues: https://github.com/Expensify/Expensify/issues/618934

Recommendation: REVERT

The change introduced a regression where individual-chat expenses appear in "Top Spenders" for track-intent users who own a paid workspace. Reverting #88752 restores the original guard and eliminates the incorrect data display without risk of a worse regression.

Assigned: @MelvinBot (PR author), @abdulrahuman5196 (approving reviewer), @dangrous (approving reviewer) from highest-confidence causing PR only
Labels: DeployBlockerCash kept (frontend bug in App); DeployBlocker not present — no label changes made.

Detailed Analysis

Evidence

• The melvin-bot comment on the issue directly identifies PR [Payment due @abdulrahuman5196] Resurface Top Spenders insight for track-intent workspace users #88752 as the causing PR.
• PR [Payment due @abdulrahuman5196] Resurface Top Spenders insight for track-intent workspace users #88752 was merged on 2026-05-11 and is included in the staging release v9.3.70-1 at position Add ability to deploy production version of iOS/Android app #75 in the chronological merge order.
• The bug is reproducible on staging and not applicable to production (new feature).
• The fix made in [Payment due @abdulrahuman5196] Resurface Top Spenders insight for track-intent workspace users #88752 changed one line in src/libs/SearchUIUtils.ts: it removed the conditional that excluded CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS from insightsSearchKeys for track-intent users, making TOP_SPENDERS always present in the array.

Verification

• Affected file: src/libs/SearchUIUtils.ts — the createTypeMenuSections function (around line 4401).
• PR [Payment due @abdulrahuman5196] Resurface Top Spenders insight for track-intent workspace users #88752 modifies exactly this file (its only production code change is the single-line diff in insightsSearchKeys).
• The suggestedSearchesVisibility[TOP_SPENDERS] check (isPaidPolicy && (isAdmin || isAuditor || isUserApprover) && memberCount >= 2) evaluates true for a track-intent user who owns a paid workspace with one invited member, so the section is shown.

Root Cause

Before PR #88752, insightsSearchKeys was:

SPEND_OVER_TIME,
...(!isTrackIntentUser ? [TOP_SPENDERS] : []),   // excluded for track-intent users
TOP_CATEGORIES,
TOP_MERCHANTS,

After the PR, TOP_SPENDERS is unconditionally included and the visibility is delegated entirely to suggestedSearchesVisibility. That visibility flag correctly gates the menu item on isPaidPolicy && memberCount >= 2, so a track-intent user with one invited member on a paid plan sees the section.

However, the TOP_SPENDERS search query (defined at line ~948) has no workspace filter — it queries all expenses by dateOn: LAST_MONTH and various statuses. This means expenses submitted to an individual chat (no policy/workspace) are included in the results. The original isTrackIntentUser exclusion prevented this from being exposed; removing it without adding a workspace-scoped query to TOP_SPENDERS caused the regression.

The appropriate fix is either to revert #88752 entirely, or to scope the TOP_SPENDERS query to exclude personal/individual-chat expenses. Given the complexity of scoping the query correctly, a revert is the safer short-term action.

[MelvinBot]

Proposal

What is the root cause of that problem?

PR #88752 made the Top Spenders insight visible to track-intent workspace users by removing the isTrackIntentUser gate at SearchUIUtils.ts:4401-4406. However, the underlying Top Spenders search query at SearchUIUtils.ts:948-965 has no policyID filter — it fetches all expenses of type=expense from the last month regardless of whether they belong to a workspace. This means IOU expenses submitted to individual chats (no workspace association) are included in Top Spenders results.

The visibility gate at SearchUIUtils.ts:1100 correctly requires isPaidPolicy && (isAdmin || isAuditor || isUserApprover) && memberCount >= 2 to show the menu item, but the query itself doesn't scope results to those eligible workspaces.

What changes do you think we should make in order to solve the problem?

Add a policyID filter to the Top Spenders search query so it only includes expenses belonging to the user's eligible paid workspaces (those that passed the visibility criteria). The query at SearchUIUtils.ts:948 needs to include the relevant policyID(s) in the buildQueryStringFromFilterFormValues call, filtering out non-workspace expenses.

Since the query is currently built statically in getSuggestedSearches, the eligible policyIDs from the visibility evaluation in getSuggestedSearchesVisibility would need to be threaded through to the query construction — either by making the Top Spenders query dynamic or by passing the eligible policyIDs as a parameter.

What alternative solutions did you explore? (Optional)

Client-side filtering of the results could also work (removing expenses with no policyID from the response), but server-side filtering via the query is more efficient and correct since it avoids fetching unnecessary data.

Note: The same missing policyID filter pattern exists in Top Categories and Top Merchants queries at SearchUIUtils.ts:653-665 — those may need the same fix.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.