Workspace -After connecting bank account the user can still see "Connect to bank" button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensifail.com
2. Sign into an applause.expensifail.com account
3. Tap on "Profile" icon > "Workspace' > "Connect bank account"
4. Proceed with the flow until the very end to successfully add the bank account
5. Return to the workspace menu and tap on any option (For example: "Issue Cards", "Pay Bills", etc.)

Expected Result:

The user expects to see the new tab options that are shown after successfully connecting a bank account

Actual Result:

The use can momentarily see the "Connect bank account" button before being shown the correct options

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.66.0

Reproducible in staging?: Yes

Reproducible in production?: No ( unable to check the VBA flow in Production)

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5584488_Workspace_options_on_Staging.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

It seems to me that this is expected and not a regression. Production currently requires the API call when opening the page before the Onyx achData is created and updated and this has been true for a while now.

If anything, this could be treated as an improvement issue as maybe we could pperform the call earlier and build the achData object immidiately after the card is added. But again, this seems like an addition rather than a regression.

CC @marcaaron, please correct me if I'm mistaken 🙇‍♂️

[Julesssss]

Reproducible in production?: No ( unable to check the VBA flow in Production)

Hi @kbecciv, does this mean that you wern't able to test this issue against production?

[kbecciv]

@Julesssss Yes, we need to use real bank credentials to test the VBA flow in Production. Tester just signed into the same user account for checking and issue does not happen in production. But I think that wasn't the best method to check.

Image.from.iOS.25.MP4

[marcaaron]

Agree with the general premise of this issue and don't think we should be blocking anything or showing an outdated UI if we have an opportunity to show an up-to-date one.

Seems most likely related to these changes -> https://github.com/Expensify/App/pull/8946/files

I think we could be resetting the VBA when we go to fetch a new one? Or is it that we just haven't fetched it yet? Not sure.

[Julesssss]

I think we could be resetting the VBA when we go to fetch a new one?

Thanks! Yeah, it did seem off that we wouldn't already immediately be updating the Onyx data after adding a card -- and waited until opening the page.

I'm going to remove this as a blocker and we can treat it as a regular External issue from here.