Skip to content

Add defaultProps to prevent crash. Fix propTypes. #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 3 commits into from
Jul 21, 2022
Merged

Add defaultProps to prevent crash. Fix propTypes. #10019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88619e6
Add report name getter for safe access
marcaaron Jul 20, 2022
2d42cf2
update defaultProps instead
marcaaron Jul 20, 2022
0f38939
Remove unneeded change
marcaaron Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/pages/ReportSettingsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,16 @@ const propTypes = {

/** The current user's notification preference for this report */
notificationPreference: PropTypes.string,

/** Access setting e.g. whether the report is "restricted" */
visibility: PropTypes.string,

/** Linked policy's ID */
policyID: PropTypes.string,
}).isRequired,

/** All reports shared with the user */
reports: PropTypes.shape({
reports: PropTypes.objectOf(PropTypes.shape({
/** The report name */
reportName: PropTypes.string,

Expand All @@ -60,7 +66,7 @@ const propTypes = {

/** ID of the policy */
policyID: PropTypes.string,
}).isRequired,
})).isRequired,

/** The policies which the user has access to and which the report could be tied to */
policies: PropTypes.shape({
Expand All @@ -74,6 +80,13 @@ const propTypes = {

const defaultProps = {
...fullPolicyDefaultProps,
report: {
reportID: 0,
reportName: '',
policyID: '',
notificationPreference: '',
visibility: '',
},
};

class ReportSettingsPage extends Component {
Expand Down