Skip to content

Add zero to amount if user entered just the decimal separator #10028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiragsalian merged 5 commits into from
Jul 29, 2022
Merged

Add zero to amount if user entered just the decimal separator #10028

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e56fae
Add zero to amount if user entered just the decimal separator
eVoloshchak Jul 20, 2022
9ffa622
Do not bind this to addLeadingZero
eVoloshchak Jul 20, 2022
c60dbcd
Merge branch 'main' into eVoloshchak_addLeadingZero
eVoloshchak Jul 27, 2022
94f918f
Fix linter error
eVoloshchak Jul 27, 2022
723e815
Cleanup
eVoloshchak Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/pages/iou/steps/IOUAmountPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,16 @@ class IOUAmountPage extends React.Component {
return amount.replace(/,/g, '');
}

/**
* Adds a leading zero to the amount if user entered just the decimal separator
*
* @param {String} amount - Changed amount from user input
* @returns {String}
*/
addLeadingZero(amount) {
return amount === '.' ? '0.' : amount;
}

/**
* Update amount with number or Backspace pressed for BigNumberPad.
* Validate new amount with decimal number regex up to 6 digits and 2 decimal digit to enable Next button
Expand All @@ -145,7 +155,7 @@ class IOUAmountPage extends React.Component {
}

this.setState((prevState) => {
const amount = `${prevState.amount}${key}`;
const amount = this.addLeadingZero(`${prevState.amount}${key}`);
return this.validateAmount(amount) ? {amount: this.stripCommaFromAmount(amount)} : prevState;
});
}
Expand All @@ -158,7 +168,7 @@ class IOUAmountPage extends React.Component {
*/
updateAmount(text) {
this.setState((prevState) => {
const amount = this.replaceAllDigits(text, this.props.fromLocaleDigit);
const amount = this.addLeadingZero(this.replaceAllDigits(text, this.props.fromLocaleDigit));
return this.validateAmount(amount)
? {amount: this.stripCommaFromAmount(amount)}
: prevState;
Expand Down