[No QA] Add DateUtils.getMicroseconds()#10143
Merged
Merged
Conversation
marcochavezf
approved these changes
Jul 27, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
Contributor
|
🚀 Deployed to staging by @neil-marcellini in version: 1.1.87-0 🚀
|
Contributor
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀
|
roryabraham
reviewed
Nov 2, 2022
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
Why did we add this? It seems pointless / misleading, because it's really just giving us milliseconds with three 0's after, right?
Most likely we can just use milliseconds everywhere this is being used, but if not and we really want microseconds, we probably need to:
- On web, use
Performance.now - On native, create a simple native lib to get the current microseconds in C++: https://stackoverflow.com/questions/32188956/get-current-timestamp-in-microseconds-since-epoch
Contributor
Author
|
Yeah it's a bit weird. At least there's a comment saying it's millisecond precision. Maybe renaming the function would be a good idea. We decided on this approach here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This util function will be used for getting keys for errors using pattern B.
Fixed Issues
$ #10066
Tests
N/A
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps
No QA
Screenshots
Web
Mobile Web
Desktop
iOS
Android