Skip to content

Scroll to top - group add list issue - Fixed #10146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Aug 2, 2022
Merged

Scroll to top - group add list issue - Fixed #10146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ddffe3
Scroll to top on select or deselect of the user
jeet-dhandha Jul 28, 2022
6e89f8d
Change implementation
jeet-dhandha Jul 28, 2022
35dc6a2
Changed comment
jeet-dhandha Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/OptionsSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ class OptionsSelector extends Component {
allOptions: newOptions,
focusedIndex: newFocusedIndex,
}, () => {
// If we just selected a new option on a multiple-selection page, scroll to the top
if (this.props.selectedOptions.length > prevProps.selectedOptions.length) {
// If we just toggled an option on a multi-selection page, scroll to top
if (this.props.selectedOptions.length !== prevProps.selectedOptions.length) {
this.scrollToIndex(0);
return;
}
Expand Down