Skip to content

[No QA] Fix bad performance trace destructuring on Android #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
Jul 29, 2022
Merged

[No QA] Fix bad performance trace destructuring on Android #10156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc5625
Stop bad destructure from crashing Android
marcaaron Jul 29, 2022
bf6ce1c
remove line
marcaaron Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libs/Firebase/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-unused-vars */
import perf from '@react-native-firebase/perf';
import lodashGet from 'lodash/get';
import * as Environment from '../Environment/Environment';
import Log from '../Log';

Expand Down Expand Up @@ -32,19 +33,19 @@ function startTrace(customEventName) {
*/
function stopTrace(customEventName) {
const stop = global.performance.now();

if (Environment.isDevelopment()) {
return;
}

const {trace, start} = traceMap[customEventName];
const trace = lodashGet(traceMap, [customEventName, 'trace']);
if (!trace) {
return;
}

trace.stop();

// Uncomment to inspect logs on release builds
// const start = lodashGet(traceMap, [customEventName, 'start']);
// Log.info(`sidebar_loaded: ${stop - start} ms`, true);

delete traceMap[customEventName];
Expand Down