Start Using BeginSignIn command and remove obsolete API command calls (Take 2)#10269
Conversation
…PI command calls""
|
Looks like you modified Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands. Unsure if your change is okay? Drop a note in #expensify-open-source! |
|
@yuwenmemon looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
| value: { | ||
| isLoading: false, | ||
| errors: { | ||
| [DateUtils.getMicroseconds()]: 'Cannot get account details, please try again', |
There was a problem hiding this comment.
Just saw this randomly. This is wrong, this is a string that should be localized. Can you send a PR to fix that please?
There was a problem hiding this comment.
Do you have a link for the context for this? These updates to errors have been breakneck - I want to make sure I have everything straight.
There was a problem hiding this comment.
Oh, wait I see it. Yeah, my bad, updating!
@robertjchen please review
Second try of #10222
Details
Start using the
BeginSignIncommand added in https://github.com/Expensify/Web-Expensify/pull/34408Fixed Issues
$ https://github.com/Expensify/Expensify/issues/218743
Tests
https://user-images.githubusercontent.com/4741899/182488142-8044224b-396a-46b2-97a2-69599c0ee76d.mp4
With the same account do the same sign in. Click "Forgot?" on the password form.
Make sure you see the following:

And that you get send a password reset link email.
Click the "Resend link" button.
Make sure you get another email
Sign in with an email that DOES NOT already have an account
Make sure that right away you see:

...And that you get an email with a sign-in link:
Sign-in with a phone number that does not have an account yet, make sure you see the following:

And that you get a text message with your magic sign-in link:

Error handling: