Skip to content

Remove unused function#10726

Merged
neil-marcellini merged 1 commit into
mainfrom
amy-cleanup-policy-custom-unit
Aug 31, 2022
Merged

Remove unused function#10726
neil-marcellini merged 1 commit into
mainfrom
amy-cleanup-policy-custom-unit

Conversation

@amyevans

Copy link
Copy Markdown
Contributor

Details

Following the deploy of #10374, Policy_CustomUnit_Update is no longer called, so it's dead code. Let's remove it! (I should've done this in the original PR but forgot)

Fixed Issues

N/A

Tests / QA

N/A

  • Verify that no errors appear in the JS console

@amyevans amyevans requested a review from a team as a code owner August 31, 2022 14:06
@amyevans amyevans self-assigned this Aug 31, 2022
@melvin-bot

melvin-bot Bot commented Aug 31, 2022

Copy link
Copy Markdown

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

@melvin-bot melvin-bot Bot requested review from neil-marcellini and removed request for a team August 31, 2022 14:07

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@neil-marcellini neil-marcellini merged commit e2a91a2 into main Aug 31, 2022
@neil-marcellini neil-marcellini deleted the amy-cleanup-policy-custom-unit branch August 31, 2022 15:45
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @neil-marcellini in version: 1.1.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants