Clear `iouReportID` param in the report Onyx key after an IOU is successfully paid by MariaHCD · Pull Request #16624 · Expensify/App

MariaHCD · 2023-03-28T15:50:22Z

The IOU report ID is not cleared in Onyx after paying, so we try to add a IOU new request to the existing, closed report which results in a 400 Unique Constraints Violation on the backend. Let's clear the iouReportID in Onyx in the successData of PayMoneyRequest

Details

Fixed Issues

$ #16105
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Prerequisites:
Account A: Account with either a silver/pending or a gold/activated wallet
Account B: Account with a gold/activated wallet

Login to NewDot with as Account A
Request money from Account B
As Account B, pay the request via Expensify
As Account A, send another request for money from Account B
Verify there is no error when requesting money

Offline tests

Requesting money when offline should create the IOU in the pending state:

QA Steps

Verify that requesting money from another account multiple times works as expected

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-28.at.3.44.30.PM.mov

Mobile Web - Chrome

XRecorder_29032023_155013.mp4

Mobile Web - Safari

Screen.Recording.2023-03-29.at.3.27.20.PM.mov

Desktop

Screen.Recording.2023-03-28.at.3.53.46.PM.mov

iOS

Screen.Recording.2023-03-29.at.3.23.50.PM.mov

Android

MelvinBot · 2023-03-29T15:59:23Z

@fedirjh @thienlnam One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MariaHCD · 2023-03-29T16:00:17Z

@fedirjh I don't think you'll be able to test this since this requires a gold/activated wallet.

MariaHCD · 2023-04-04T15:20:06Z

Friendly bump on reviews @Gonals @thienlnam 🙏🏼

thienlnam

Change looks good, but can't run through the checklist screenshots right now 😢
This is a pretty small change though so not too worried about it failing

MariaHCD · 2023-04-05T15:36:52Z

I think @Gonals is going to be ooo for the rest of the week so tagging pullerbear again for review + tests 🙏🏼

MelvinBot · 2023-04-05T15:37:02Z

@Santhosh-Sellavel @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MariaHCD · 2023-04-05T15:38:20Z

Gold/activated wallets aren't available for contributors so @Santhosh-Sellavel can't test this, unfortunately.

thienlnam · 2023-04-05T17:53:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thienlnam · 2023-04-05T17:54:12Z

@Julesssss Sorry, my simulators are broken right now - could you please test the ios / android native? I can complete the rest of the platforms

Julesssss · 2023-04-06T16:42:13Z

Hey all, I'm sorry but I ran out of time today to test this on iOS/Android. This was one of 16 items on my 10am todo list and I didn't quite have time for everything 😞

It's still at the top of my list, but we have a 4 day bank holiday in the UK starting tomorrow. If you are happy to wait until Tuesday I can test both native Android and iOS. Hope that's not too annoying!

MariaHCD · 2023-04-07T08:33:15Z

No worries, @Julesssss! This feature is behind a beta so this bug shouldn't be affecting too many people right now.

Julesssss · 2023-04-11T10:34:05Z

Okay, I'm back and trying to run through the steps. I get stuck here though, as I'm prompted to add additional details via Onfido as my silver wallet user. Is there a way to avoid this check? (userA has a gold wallet, userB has a silver wallet added via the cliTools add bank account script):

Pay via Expensify as Account B

MariaHCD · 2023-04-11T12:27:07Z

@Julesssss Oh, sorry, I think my instructions are a bit off, Account B should be the one with a Gold/Activated wallet 😅

I've updated the test steps to be more clear.

Julesssss

With @MariaHCD's help I was able to configure the wallet correctly. Unfortunately, the issue is still occuring for me on iOS, which is quite confusing... I can see Maria was successful, but even after a fresh install I'm seeing the error 😖

I'm also struggling to get Android to build on my new machine.

Screen.Recording.2023-04-11.at.15.25.52.mov

I have verified on all platforms except native and added the screenshots.

Julesssss · 2023-04-11T16:03:00Z

Finished configuring my Android emulator and I'm seeing the same issue. It seems odd that this only occurs on native :/

I see that Maria didn't have this problem originally... @thienlnam have you been able to configure iOS/Android in the meantime? It would be good to determine whether this is just an issue on my end or not.

thienlnam · 2023-04-12T00:28:38Z

Screen.Recording.2023-04-11.at.5.27.05.PM.mov

So I fixed my ios simulator.. but android is still borked. It seems to be working fine for me. I added the recording just so you can check that I'm doing it correctly

thienlnam

I think we can move forward with merging since it's working for me in IOS at least - will leave the final call up to you all

Julesssss · 2023-04-12T09:58:51Z

I'm going to try one last time this morning after updating all repos.

OSBotify · 2023-04-12T10:22:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss

Okay, I'm still confused, but I located the error and it doesn't seem related to the changes:

OSBotify · 2023-04-13T03:44:03Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-17T22:58:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Clear the iouReportID param in the report Onyx key after paying the IOU

e333956

MariaHCD self-assigned this Mar 28, 2023

MariaHCD requested a review from Gonals March 28, 2023 15:50

MariaHCD mentioned this pull request Mar 28, 2023

[$1000] IOU - Request money flow breaks on second time after the 1st one paid #16105

Closed

6 tasks

Fix trailing space

04b9d5c

MariaHCD marked this pull request as ready for review March 29, 2023 15:58

MariaHCD requested a review from a team as a code owner March 29, 2023 15:58

melvin-bot Bot requested review from fedirjh and thienlnam and removed request for a team March 29, 2023 15:59

thienlnam removed the request for review from fedirjh March 29, 2023 16:55

thienlnam approved these changes Apr 4, 2023

View reviewed changes

MariaHCD requested a review from a team April 5, 2023 15:36

melvin-bot Bot requested review from Julesssss and Santhosh-Sellavel and removed request for a team April 5, 2023 15:37

MariaHCD removed the request for review from Santhosh-Sellavel April 5, 2023 15:37

Julesssss approved these changes Apr 6, 2023

View reviewed changes

Julesssss added the Ready To Build label Apr 6, 2023

Julesssss reviewed Apr 11, 2023

View reviewed changes

Julesssss removed the Ready To Build label Apr 11, 2023

thienlnam approved these changes Apr 12, 2023

View reviewed changes

Gonals approved these changes Apr 12, 2023

View reviewed changes

Gonals merged commit 5d69c8e into main Apr 12, 2023

Gonals deleted the maria-clear-iou-report-id branch April 12, 2023 10:16

Julesssss reviewed Apr 12, 2023

View reviewed changes

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

Conversation

MariaHCD commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 29, 2023

Uh oh!

MariaHCD commented Mar 29, 2023

Uh oh!

MariaHCD commented Apr 4, 2023

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

MariaHCD commented Apr 5, 2023

Uh oh!

MelvinBot commented Apr 5, 2023

Uh oh!

MariaHCD commented Apr 5, 2023

Uh oh!

thienlnam commented Apr 5, 2023 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

thienlnam commented Apr 5, 2023

Uh oh!

Julesssss commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariaHCD commented Apr 7, 2023

Uh oh!

Julesssss commented Apr 11, 2023

Uh oh!

MariaHCD commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Apr 11, 2023

Uh oh!

thienlnam commented Apr 12, 2023

Uh oh!

thienlnam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Apr 12, 2023

Uh oh!

OSBotify commented Apr 12, 2023

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 13, 2023

Uh oh!

OSBotify commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MariaHCD commented Mar 28, 2023 •

edited

Loading

thienlnam commented Apr 5, 2023 •

edited by Julesssss

Loading

Julesssss commented Apr 6, 2023 •

edited

Loading

MariaHCD commented Apr 11, 2023 •

edited

Loading

Julesssss left a comment •

edited

Loading

thienlnam left a comment •

edited

Loading