fix: constrain min and max age date for dob pickers by koko57 · Pull Request #17072 · Expensify/App

koko57 · 2023-04-06T12:54:34Z

Details

Fixed Issues

$ #16691
PROPOSAL: #16691(COMMENT) - alternative solution

Tests

Go Settings -> Workspaces -> [Select your workspace] -> Issue cards -> Connect Bank Account -> Connect manually
Fill out the 1 and 2 steps of the form (Incorporation Date date picker should have no constraints)
Proceed to Personal Information Step - DOB date picker dates should be constrained to the current date - 18 years. Minimum date from the past should be 150 years back from now.
--- AdditionalDetailsStep
Go to back to Settings then -> Payments -> Transfer Balance (if you have this option) -> Additional Details Step should appear
Date picker for DOB should have the same constraints as described in 3.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go Settings -> Workspaces -> [Select your workspace] -> Issue cards -> Connect Bank Account -> Connect manually
Fill out the 1 and 2 steps of the form (Incorporation Date date picker should have no constraints)
Proceed to Personal Information Step - DOB date picker dates should be constrained to the current date - 18 years. Minimum date from the past should be 150 years back from now.
--- AdditionalDetailsStep
Go to back to Settings then -> Payments -> Transfer Balance (if you have this option) -> Additional Details Step should appear
Date picker for DOB should have the same constraints as described in 3.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

#16691 (comment)

Desktop

iOS

Android

MelvinBot · 2023-04-06T12:54:38Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

ArekChr · 2023-04-06T13:39:05Z

     */
    defaultValue: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),
+
+    minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),


Suggested change

minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),

/** A minimum date (oldest) allowed to select */

minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),

ArekChr · 2023-04-06T13:39:18Z

    defaultValue: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),
+
+    minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),
+    maxDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),


Suggested change

maxDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),

/** A maximum date (earliest) allowed to select */

maxDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),

ArekChr · 2023-04-06T13:47:41Z

        this.showPicker = this.showPicker.bind(this);
        this.setDate = this.setDate.bind(this);
+
+        this.maxDate = this.props.maxDate || new Date(CONST.DATE.MAX_DATE);


Too many repetition, lets move new new Date(CONST.DATE.MAX_DATE) and new Date(CONST.DATE.MIN_DATE) to default props

ArekChr · 2023-04-06T13:49:07Z

     */
    defaultValue: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),
+
+    minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),


I suggest unifying the types to a single type, Date instead of a Date or a string

MelvinBot · 2023-04-07T14:44:57Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-04-07T15:00:20Z

I'm not sure why it doesn't request review from assigned CME or C+ on the issue

alexxxwork · 2023-04-07T16:54:17Z

I'm not sure why it doesn't request review from assigned CME or C+ on the issue

@Santhosh-Sellavel Because you need to mention them in the first (comment) line of the PR template. And it works only once on PR creation.

Santhosh-Sellavel · 2023-04-07T17:35:56Z

Oh yes seems @koko57 missed including issue link while creating PR

alexxxwork · 2023-04-07T18:02:05Z

Oh yes seems @koko57 missed including issue link while creating PR

@Santhosh-Sellavel automatic reviewers assignment works based on first line of PR only, and not on linked issue.

Santhosh-Sellavel · 2023-04-07T18:06:27Z

Sorry, that's not the case, it happens from issue linking only where details of CME & C+ are taken and requests review from them check at old PRs. We had to do it right the first time while submitting it's ready for review or it messes up.

Santhosh-Sellavel

Adding myself as reviewer

alexxxwork · 2023-04-07T18:33:19Z

Sorry, that's not the case, it happens from issue linking only where details of CME & C+ are taken and requests review from them check at old PRs. We had to do it right the first time while submitting it's ready for review or it messes up.

Well, then I'm not shure how it works. In this PR there was a correctly linked issue, but I've accidently moved mentioned reviewers on the second line so PullerBear hadn't assigned anyone.

Santhosh-Sellavel · 2023-04-07T19:20:11Z

But I'm sure about how this work, that's why have the following as the first checklist item.

I linked the correct issue in the ### Fixed Issues section above

thienlnam · 2023-04-10T18:09:18Z

Adding @deetergp to this since this is from the issue he is CME on

Santhosh-Sellavel · 2023-04-10T19:35:16Z

+        this.inputRef.setAttribute('max', moment(this.props.maxDate).format(CONST.DATE.MOMENT_FORMAT_STRING));
+        this.inputRef.setAttribute('min', moment(this.props.minDate).format(CONST.DATE.MOMENT_FORMAT_STRING));


Why do we need to format it here?

For min and max attribute input type="date" accepts a formatted string (yyyy-mm-dd). We pass the prop in Date format, so it needs to be formatted to work properly. We do the same for the value and the defaultValue.

mountiny

Looking good, @Santhosh-Sellavel will you be able to run through the testing and checklist?

Santhosh-Sellavel · 2023-04-12T14:43:31Z

Ah missed this one, will get it done today.

Santhosh-Sellavel · 2023-04-12T18:39:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-04-13.at.12.04.22.AM.mov

Mobile Web - Chrome

Screen_Recording_20230413_002721_Chrome.mp4

Mobile Web - Safari

N/A as it fails we already know

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-13.at.00.35.11.mp4

Android

Screen_Recording_20230413_002531_New.Expensify.mp4

Santhosh-Sellavel

Mostly looks and tests wells!

Santhosh-Sellavel · 2023-04-12T19:10:58Z

+        this.minDate = moment().subtract(CONST.DATE_BIRTH.MAX_AGE, 'Y').toDate();
+        this.maxDate = moment().subtract(CONST.DATE_BIRTH.MIN_AGE_FOR_PAYMENT, 'Y').toDate();


Repeating this logic twice looks a bit off to me @mountiny @deetergp

NAB, since they're one-liners and I'm not going to lose sleep over it. But since you bring it up, maybe it makes more sense to put the logic in the DatePicker component since both pages use it.

deetergp · 2023-04-12T21:23:05Z

+        this.minDate = moment().subtract(CONST.DATE_BIRTH.MAX_AGE, 'Y').toDate();
+        this.maxDate = moment().subtract(CONST.DATE_BIRTH.MIN_AGE_FOR_PAYMENT, 'Y').toDate();


NAB, since they're one-liners and I'm not going to lose sleep over it. But since you bring it up, maybe it makes more sense to put the logic in the DatePicker component since both pages use it.

Santhosh-Sellavel · 2023-04-12T22:40:44Z

Cool @deetergp Since we are going to remove old DatePicker soon, Lets merge this one.

OSBotify · 2023-04-12T23:18:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-13T03:43:27Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-17T22:57:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: constrain min and max age date for dob pickers

f796d60

ArekChr reviewed Apr 6, 2023

View reviewed changes

koko57 added 3 commits April 6, 2023 16:39

fix: apply requested changes

a7591bf

fix: change min and max date propType

886dd09

Merge branch 'Expensify:main' into fix/16691-date-picker-no-constraint

da1d485

koko57 marked this pull request as ready for review April 7, 2023 14:44

koko57 requested a review from a team as a code owner April 7, 2023 14:44

koko57 mentioned this pull request Apr 7, 2023

[HOLD for payment 2023-04-25] [$250] Date picker in “Personal Information” form of Connect bank account doesn’t constrain dropdown year options should be current year minus 18 years #16691

Closed

6 tasks

melvin-bot Bot requested review from thienlnam and removed request for a team April 7, 2023 14:44

Santhosh-Sellavel reviewed Apr 7, 2023

View reviewed changes

thienlnam requested review from deetergp and removed request for thienlnam April 10, 2023 18:08

Santhosh-Sellavel suggested changes Apr 10, 2023

View reviewed changes

mountiny assigned koko57 Apr 12, 2023

mountiny reviewed Apr 12, 2023

View reviewed changes

Santhosh-Sellavel reviewed Apr 12, 2023

View reviewed changes

deetergp approved these changes Apr 12, 2023

View reviewed changes

deetergp merged commit 1b756ef into Expensify:main Apr 12, 2023

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

francoisl mentioned this pull request Apr 15, 2023

[HOLD for payment 2023-05-05] [$1000] Connect Bank Account -Selecting the oldest available date gives an error "Must be over 18 years old" #17426

Closed

6 tasks

koko57 deleted the fix/16691-date-picker-no-constraint branch April 18, 2023 06:19

	minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),
	/** A minimum date (oldest) allowed to select */
	minDate: PropTypes.oneOfType([PropTypes.instanceOf(Date), PropTypes.string]),

		this.inputRef.setAttribute('max', moment(this.props.maxDate).format(CONST.DATE.MOMENT_FORMAT_STRING));
		this.inputRef.setAttribute('min', moment(this.props.minDate).format(CONST.DATE.MOMENT_FORMAT_STRING));

		this.minDate = moment().subtract(CONST.DATE_BIRTH.MAX_AGE, 'Y').toDate();
		this.maxDate = moment().subtract(CONST.DATE_BIRTH.MIN_AGE_FOR_PAYMENT, 'Y').toDate();

Conversation

koko57 commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MelvinBot commented Apr 7, 2023

Uh oh!

Santhosh-Sellavel commented Apr 7, 2023

Uh oh!

alexxxwork commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Apr 7, 2023

Uh oh!

alexxxwork commented Apr 7, 2023

Uh oh!

Santhosh-Sellavel commented Apr 7, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

alexxxwork commented Apr 7, 2023

Uh oh!

Santhosh-Sellavel commented Apr 7, 2023

Uh oh!

thienlnam commented Apr 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Apr 12, 2023

Uh oh!

Santhosh-Sellavel commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Apr 12, 2023

Uh oh!

OSBotify commented Apr 12, 2023

Uh oh!

OSBotify commented Apr 13, 2023

Uh oh!

OSBotify commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

koko57 commented Apr 6, 2023 •

edited

Loading

alexxxwork commented Apr 7, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 12, 2023 •

edited

Loading