[User Settings] Add new Change Password view#1770
Merged
NikkiWines merged 10 commits intoMar 18, 2021
Merged
Conversation
Maftalion
commented
Mar 15, 2021
Maftalion
commented
Mar 15, 2021
shawnborton
reviewed
Mar 15, 2021
shawnborton
reviewed
Mar 15, 2021
francoisl
reviewed
Mar 15, 2021
NikkiWines
previously approved these changes
Mar 16, 2021
NikkiWines
left a comment
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
Tested with both a 2FA account and non-2FA account. Works great!
Contributor
|
@Maftalion just FYI you have some conflicts that are preventing this from getting merged |
# Conflicts: # src/pages/settings/PasswordPage.js
Contributor
Author
|
@NikkiWines updated! |
NikkiWines
dismissed
their stale review
forgot that we had to add an extra line of text below the password input
francoisl
previously approved these changes
Mar 17, 2021
NikkiWines
reviewed
Mar 18, 2021
NikkiWines
left a comment
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
This looks great. Looks like Michelle had some comments on the sub-text so not approving but will do so as soon as that's updated!
shawnborton
reviewed
Mar 18, 2021
Contributor
Author
|
With the new
|
Contributor
|
Quick copy tweak -- it currently says |
francoisl
reviewed
Mar 18, 2021
NikkiWines
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Fixes https://github.com//issues/1710Tests
Tested On
Screenshots
Success
Screen.Recording.2021-03-14.at.8.56.16.PM.mov
Error
Web
Mobile Web
Desktop
iOS
Android