Remove slack notifications for QA#1776
Merged
Merged
Conversation
roryabraham
approved these changes
Mar 15, 2021
roryabraham
left a comment
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
Yep, this looks right to me 👍
alex-mechler
approved these changes
Mar 15, 2021
alex-mechler
left a comment
alex-mechler
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but holding off merging until we see if QA uses them
Contributor
|
I think they said they are using them, so we'll hold off until we have the new checklists in place (should be very soon, today or tomorrow). |
roryabraham
changed the title
roryabraham
changed the title
Contributor
|
Merging this, they shouldn't need these anymore. |
85 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>
Details
Fixed Issues
https://github.com/Expensify/Expensify/issues/157452
Tests
None, we can check the notifications are gone when we merge it