Create GH Action to reliably determine mergeability#1847
Merged
Conversation
AndrewGable
reviewed
Mar 17, 2021
AndrewGable
reviewed
Mar 17, 2021
AndrewGable
approved these changes
Mar 17, 2021
Jag96
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When getting ready to automerge a PR, we want to first make sure that it's mergeable. However, Github uses a background job to calculate mergeability... from the GH docs:
So we can't rely on the boolean result of the mergeable attribute to be readily available. This PR creates a custom Github Action to continually poll mergeability of a PR until the result is non-null, and output the end result.
Fixed Issues
Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2133374703?check_suite_focus=true
Tests
Added automated tests for the new JS action.
Need to test it's usage in the workflow by merging this PR.