Skip to content

Auto focus Message input field on workspace invite member page #18791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hayata-suenaga merged 2 commits into from
May 18, 2023
Merged

Auto focus Message input field on workspace invite member page #18791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6c7ab
Auto focus message input field
PrashantMangukiya May 11, 2023
d912714
Update logic to support focus after refresh
PrashantMangukiya May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/pages/workspace/WorkspaceInviteMessagePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,17 @@ class WorkspaceInviteMessagePage extends React.Component {
};
}

componentDidMount() {
this.focusTimeout = setTimeout(() => {
Comment thread
hayata-suenaga marked this conversation as resolved.
this.welcomeMessageInputRef.focus();
// Below condition is needed for web, desktop and mweb only, for native cursor is set at end by default.
if (this.welcomeMessageInputRef.value && this.welcomeMessageInputRef.setSelectionRange) {
const length = this.welcomeMessageInputRef.value.length;
this.welcomeMessageInputRef.setSelectionRange(length, length);
}
Comment on lines +84 to +88

@Santhosh-Sellavel Santhosh-Sellavel Jun 20, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is caused a regression here #20875 (comment).

Why do we need this?

@hayata-suenaga hayata-suenaga Jun 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @mollfpr @PrashantMangukiya

@mollfpr mollfpr Jun 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is #20875 a regression of this?

On the native the cursor is set at the end of the text, so we want the same behavior for the web and desktop.

}, CONST.ANIMATED_TRANSITION);
}

componentDidUpdate(prevProps) {
if (
!(
Expand All @@ -90,6 +101,13 @@ class WorkspaceInviteMessagePage extends React.Component {
this.setState({welcomeNote: this.getDefaultWelcomeNote()});
}

componentWillUnmount() {
if (!this.focusTimeout) {
return;
}
clearTimeout(this.focusTimeout);
}

getDefaultWelcomeNote() {
return this.props.translate('workspace.inviteMessage.welcomeNote', {
workspaceName: this.props.policy.name,
Expand Down Expand Up @@ -176,6 +194,7 @@ class WorkspaceInviteMessagePage extends React.Component {
</View>
<View style={[styles.mb3]}>
<TextInput
ref={(el) => (this.welcomeMessageInputRef = el)}
inputID="welcomeMessage"
label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
autoCompleteType="off"
Expand Down