Use IOU/Expense reportID for IOU actions#18856
Closed
luacmartins wants to merge 7 commits into
Closed
Conversation
|
@s77rt @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
56 tasks
Contributor
Author
|
Closing this in favor of #18604 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the IOU reportAction to the IOU/Expense report instead of the parent chatReport.
We are gonna start creating IOU reportActions directly in the IOU/Expense report and as part of the switch, we are temporarily skipping test so that Auth integration tests pass. The plan to make the switch is:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/281893
Web Tests
Will be tested with the App PR
Mobile Tests
N/A
Automated Auth Tests
Updated tests
Query Timings/Plans
N/A