Skip to content

Revert "Fix Image Flashing Bug" #19145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasperhuangg wants to merge 1 commit into from
Closed

Revert "Fix Image Flashing Bug" #19145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/ReportScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ class ReportScreen extends React.Component {
}
>
<FullPageNotFoundView
shouldShow={(!reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}
shouldShow={(!this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}
subtitleKey="notFound.noAccess"
shouldShowCloseButton={false}
shouldShowBackButton={this.props.isSmallScreenWidth}
Expand Down
5 changes: 4 additions & 1 deletion src/pages/home/report/ReportActionItemThread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import withWindowDimensions, {windowDimensionsPropTypes} from '../../../componen
import CONST from '../../../CONST';
import avatarPropTypes from '../../../components/avatarPropTypes';
import MultipleAvatars from '../../../components/MultipleAvatars';
import Navigation from '../../../libs/Navigation/Navigation';
import ROUTES from '../../../ROUTES';
import compose from '../../../libs/compose';

const propTypes = {
Expand Down Expand Up @@ -41,7 +43,8 @@ const ReportActionItemThread = (props) => {
<View style={[styles.chatItemMessage]}>
<Pressable
onPress={() => {
Report.navigateToAndOpenChildReport(props.childReportID);
Report.openReport(props.childReportID);
Navigation.navigate(ROUTES.getReportRoute(props.childReportID));
}}
>
<View style={[styles.flexRow, styles.alignItemsCenter, styles.mt2]}>
Expand Down