Create lockDeploys workflow#1938
Conversation
|
Testing step 1: LockDeploys workflow: https://github.com/Expensify/Expensify.cash/runs/2151878987?check_suite_focus=true preDeploy after master PR was merged: https://github.com/Expensify/Expensify.cash/actions/runs/669167652 StagingDeployCash updated #1926 |
|
Automerge master failed silently https://github.com/Expensify/Expensify.cash/runs/2151890115?check_suite_focus=true So our new version wasn't updated on To resolve, we'll make sure there are no automerge jobs going either, and pull master after waiting. |
|
Testing step 1 round 2: lockDeploys workflow: https://github.com/Expensify/Expensify.cash/actions/runs/669259652 I think that after the |
|
Testing step 1 round 3: lockDeploys workflow: https://github.com/Expensify/Expensify.cash/actions/runs/669426206 The fact that |

Details
To avoid a race condition between this job and
preDeploy:version, added a new action called https://github.com/TomChv/wait-my-workflow/ . Tested in Public-Test-Repo and seems to work well.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155210
Tests
🔐 LockCashDeploys 🔐label to theStagingDeployCash. We should then expect that:lockDeploysworkflow should wait for thepreDeploy::versionjob to finish before proceeding pastwait-my-workflow. But then once it does...bumpVersionaction should be executed w/SEMVER_LEVEL = PATCHPATCHversionpreDeployworkflow runs again, an automerge PR should be merged to staging from master.StagingDeployCashshould be updated with the newPATCHversionStagingDeployCashshould not be modifiedStagingDeployCash, and:PATCHversion created in step 1BUILDversion should be bumped on masterBUILDversion on master.StagingDeployCashshould be created, and should include the PR merged in step 2.🔐 LockCashDeploys 🔐to some random issue, and this workflow should be skipped.