Update User_UploadAvatar to take in a file instead of a base64 image#1966
Merged
Conversation
Contributor
Author
|
off hold now that https://github.com/Expensify/Web-Expensify/pull/30517 has been deployed to prod! |
5 tasks
thienlnam
approved these changes
Mar 24, 2021
85 tasks
|
@NikkiWines Hello! This one looks like internal QA. If so, can you let me know when it's QAd so I can check it off? Thanks in advance! |
Contributor
Author
|
@isagoico Ah I don't think this can be QA'd at all, sorry! Forgot we added staging to E.cash now |
|
No worries at all! Thanks for the quick answer. Checking it off as No QA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Held upon https://github.com/Expensify/Web-Expensify/pull/30517
Details
Updates User_Upload avatar so that it doesn't have to take in a base64 image string to work.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/156268Tests
Uploadand then continue execution
4. Wait a few seconds and confirm your profile picture is updated.
5. Refresh the page and confirm your user avatar is updated.
Tested On
Screenshots
N/A
cc: @marcaaron since we discussed this