Introduce translations and translate library for internationalization#1969
Conversation
| @@ -0,0 +1,9 @@ | |||
| import en from './en'; | |||
| import es from './es'; | |||
| import esES from './es-ES'; | |||
There was a problem hiding this comment.
Can we not name this es-ES instead of esES ?
There was a problem hiding this comment.
In JS, variable/module/function names can't contain -. Maybe, we can use _ here instead.
|
@tugbadogan Hello! This PR looks like internal QA. If so, can you let me know when it's QA'd in staging so I can check it off the deploy list? Thanks in advance! |
|
@isagoico Sorry, what does internal QA mean? I’m not sure if it applies to this PR. |
|
@tugbadogan, could you please do your best to write up a set of steps that can be taken to verify that this PR works as expected? We're working on implementing a QA process, so going forward we're going to need QA steps for all PRs so that they can undergo QA before being deployed to production. |
|
@roryabraham this is not QAable really, since it's part of a larger project and this is just one of the bases of that project. We will be able to do QA following the test steps defined in the design doc, once all the pieces are done. |
|
Thanks @iwiznia! So in that case @tugbadogan, no need to follow-up on this comment 😄 |
5 participants
@iwiznia @arielgreen
Details
Fixed Issues
Fixes #1844
Tests
Unit Tests are added.
Manually tested function to see if it returns translated string or logs an alert to server.
Tested On