Migrate NewChatPage to functional component #20170
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import _ from 'underscore'; | ||
| import React, {useState, useEffect, useMemo} from 'react'; | ||
| import {View} from 'react-native'; | ||
| import PropTypes from 'prop-types'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
|
|
@@ -44,148 +44,98 @@ const defaultProps = { | |
| reports: {}, | ||
| }; | ||
|
|
||
| const excludedGroupEmails = _.without(CONST.EXPENSIFY_EMAILS, CONST.EMAIL.CONCIERGE); | ||
|
|
||
| function NewChatPage(props) { | ||
| const [searchTerm, setSearchTerm] = useState(''); | ||
| const [filteredRecentReports, setFilteredRecentReports] = useState([]); | ||
| const [filteredPersonalDetails, setFilteredPersonalDetails] = useState([]); | ||
| const [filteredUserToInvite, setFilteredUserToInvite] = useState(); | ||
| const [selectedOptions, setSelectedOptions] = useState([]); | ||
|
|
||
| const maxParticipantsReached = selectedOptions.length === CONST.REPORT.MAXIMUM_PARTICIPANTS; | ||
| const headerMessage = OptionsListUtils.getHeaderMessage( | ||
| filteredPersonalDetails.length + filteredRecentReports.length !== 0, | ||
| Boolean(filteredUserToInvite), | ||
| searchTerm, | ||
| maxParticipantsReached, | ||
| ); | ||
| const isOptionsDataReady = ReportUtils.isReportDataReady() && OptionsListUtils.isPersonalDetailsReady(props.personalDetails); | ||
|
|
||
| const sections = useMemo(() => { | ||
|
Contributor
Author
There was a problem hiding this comment. I used But I propose to remove it following the guidelines in React docs -
2 and 3 are not applicable here. For the first point, the dependencies change often in our case which would anyway recalculate the value. If you agree then we can remove it from
Contributor
Author
There was a problem hiding this comment. discussion on useCallback, useMemo in slack
Contributor
Author
There was a problem hiding this comment. @aimane-chnaif I will remove useMemo here if you agree.
Contributor
There was a problem hiding this comment. I think so. I don't see much benefit of performance improvement using |
||
| const sectionsList = []; | ||
| let indexOffset = 0; | ||
|
|
||
| if (props.isGroupChat) { | ||
| sectionsList.push({ | ||
| title: undefined, | ||
| data: selectedOptions, | ||
| shouldShow: !_.isEmpty(selectedOptions), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += selectedOptions.length; | ||
|
|
||
| if (maxParticipantsReached) { | ||
| return sectionsList; | ||
| } | ||
| } | ||
|
|
||
| // Filtering out selected users from the search results | ||
| const filterText = _.reduce(selectedOptions, (str, {login}) => `${str} ${login}`, ''); | ||
| const recentReportsWithoutSelected = _.filter(filteredRecentReports, ({login}) => !filterText.includes(login)); | ||
| const personalDetailsWithoutSelected = _.filter(filteredPersonalDetails, ({login}) => !filterText.includes(login)); | ||
| const hasUnselectedUserToInvite = filteredUserToInvite && !filterText.includes(filteredUserToInvite.login); | ||
|
|
||
| sectionsList.push({ | ||
| title: props.translate('common.recents'), | ||
| data: recentReportsWithoutSelected, | ||
| shouldShow: !_.isEmpty(recentReportsWithoutSelected), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += recentReportsWithoutSelected.length; | ||
|
|
||
| sectionsList.push({ | ||
| title: props.translate('common.contacts'), | ||
| data: personalDetailsWithoutSelected, | ||
| shouldShow: !_.isEmpty(personalDetailsWithoutSelected), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += personalDetailsWithoutSelected.length; | ||
|
|
||
| if (hasUnselectedUserToInvite) { | ||
| sectionsList.push({ | ||
| title: undefined, | ||
| data: [filteredUserToInvite], | ||
| shouldShow: true, | ||
| indexOffset, | ||
| }); | ||
| } | ||
|
|
||
| return sectionsList; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [filteredPersonalDetails, filteredRecentReports, filteredUserToInvite, maxParticipantsReached, props.isGroupChat, selectedOptions]); | ||
|
|
||
| /** | ||
| * Removes a selected option from list if already selected. If not already selected add this option to the list. | ||
| * @param {Object} option | ||
| */ | ||
| function toggleOption(option) { | ||
| const isOptionInList = _.some(selectedOptions, (selectedOption) => selectedOption.login === option.login); | ||
|
|
||
| let newSelectedOptions; | ||
|
|
||
| if (isOptionInList) { | ||
| newSelectedOptions = _.reject(selectedOptions, (selectedOption) => selectedOption.login === option.login); | ||
| } else { | ||
| newSelectedOptions = [...selectedOptions, option]; | ||
| } | ||
|
|
||
| const {recentReports, personalDetails, userToInvite} = OptionsListUtils.getNewChatOptions(props.reports, props.personalDetails, props.betas, searchTerm, [], excludedGroupEmails); | ||
|
|
||
| setSelectedOptions(newSelectedOptions); | ||
| setFilteredRecentReports(recentReports); | ||
| setFilteredPersonalDetails(personalDetails); | ||
| setFilteredUserToInvite(userToInvite); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -194,73 +144,77 @@ class NewChatPage extends Component { | |
| * | ||
| * @param {Object} option | ||
| */ | ||
| function createChat(option) { | ||
| Report.navigateToAndOpenReport([option.login]); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a new group chat with all the selected options and the current user, | ||
| * or navigates to the existing chat if one with those participants already exists. | ||
| */ | ||
| const createGroup = () => { | ||
|
Contributor
Author
There was a problem hiding this comment. didn't use function here as it was passed down as prop |
||
| if (!props.isGroupChat) { | ||
| return; | ||
| } | ||
| const logins = _.pluck(selectedOptions, 'login'); | ||
| if (logins.length < 1) { | ||
| return; | ||
| } | ||
| Report.navigateToAndOpenReport(logins); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| const {recentReports, personalDetails, userToInvite} = OptionsListUtils.getNewChatOptions( | ||
| props.reports, | ||
| props.personalDetails, | ||
| props.betas, | ||
| searchTerm, | ||
| [], | ||
| props.isGroupChat ? excludedGroupEmails : [], | ||
| ); | ||
| setFilteredRecentReports(recentReports); | ||
| setFilteredPersonalDetails(personalDetails); | ||
| setFilteredUserToInvite(userToInvite); | ||
| // props.betas and props.isGroupChat are not added as dependencies since they don't change during the component lifecycle | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [props.reports, props.personalDetails, searchTerm]); | ||
|
|
||
| return ( | ||
| <ScreenWrapper | ||
| includeSafeAreaPaddingBottom={false} | ||
| shouldEnableMaxHeight | ||
| > | ||
| {({didScreenTransitionEnd, safeAreaPaddingBottomStyle}) => ( | ||
| <> | ||
| <HeaderWithBackButton title={props.isGroupChat ? props.translate('sidebarScreen.newGroup') : props.translate('sidebarScreen.newChat')} /> | ||
| <View style={[styles.flex1, styles.w100, styles.pRelative, selectedOptions.length > 0 ? safeAreaPaddingBottomStyle : {}]}> | ||
| <OptionsSelector | ||
| canSelectMultipleOptions={props.isGroupChat} | ||
| sections={sections} | ||
| selectedOptions={selectedOptions} | ||
| value={searchTerm} | ||
| onSelectRow={(option) => (props.isGroupChat ? toggleOption(option) : createChat(option))} | ||
| onChangeText={setSearchTerm} | ||
| headerMessage={headerMessage} | ||
| boldStyle | ||
| shouldFocusOnSelectRow={props.isGroupChat && !Browser.isMobile()} | ||
| shouldShowConfirmButton={props.isGroupChat} | ||
| shouldShowOptions={didScreenTransitionEnd && isOptionsDataReady} | ||
| confirmButtonText={props.translate('newChatPage.createGroup')} | ||
| onConfirmSelection={createGroup} | ||
| textInputLabel={props.translate('optionsSelector.nameEmailOrPhoneNumber')} | ||
| safeAreaPaddingBottomStyle={safeAreaPaddingBottomStyle} | ||
| /> | ||
| </View> | ||
| </> | ||
| )} | ||
| </ScreenWrapper> | ||
| ); | ||
| } | ||
|
|
||
| NewChatPage.propTypes = propTypes; | ||
| NewChatPage.defaultProps = defaultProps; | ||
| NewChatPage.displayName = 'NewChatPage'; | ||
|
|
||
| export default compose( | ||
| withLocalize, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using function based on the discussion here