Create separate build configuration for staging#2064
Merged
Conversation
|
npm has a |
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Contributor
Author
|
Yes, I did run a local build: No errors. |
|
npm has a |
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
AndrewGable
reviewed
Mar 25, 2021
| const dotenv = require('dotenv'); | ||
| const common = require('./webpack.common.js'); | ||
|
|
||
| const env = dotenv.config({path: path.resolve(__dirname, '../../.env.staging')}).parsed; |
Contributor
There was a problem hiding this comment.
Is this the only difference between prod/staging? Is there a way to DRY this up more?
Contributor
Author
There was a problem hiding this comment.
DRYed up a bit 👍
AndrewGable
approved these changes
Mar 25, 2021
MariaHCD
approved these changes
Mar 25, 2021
85 tasks
Contributor
Author
|
Nice, this seemed to have worked 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
There are many CORS errors on https://staging.expensify.cash
And it is because it is using the wrong value for the
EXPENSIFY_URL_CASHenvironment variable.Fixed Issues
No issue, hot-fixing staging.
Tests
Tested with local build, which is the best we can do for now.