cleanup for GSD layout#2104
Conversation
|
Updated. Thanks. |
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Thanks for the changes looks much better. Have one more thought and then I'll stop bugging you 😅
|
@parasharrajat see my comment over here: #2123 (comment) In case we want to fix that while you are addressing clean up items here. |
|
@shawnborton Thanks for mapping that issue to the PR. It's been taken care of. |
| }, | ||
|
|
||
| focusedAvatar: { | ||
| backgroundColor: themeColors.pillBG, |
There was a problem hiding this comment.
These variables were removed recently so I have to migrate.
|
@parasharrajat you've got some conflicts here now and please try to remove all inline styles. We should not be passing any objects directly to a |
|
@marcaaron Updated. Thanks. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
I believe this PR may have caused a regression where the background between the avatars becomes black when the option is selected:
Note: reproducible on staging but not production so this should be a deploy blocker. |
|
Oh. I think this PR should fix this. Let me check. |
|
Oops, ignore me, I was not on the latest staging version. |
5 participants
@marcaaron Please review.
Fixes
fixes #2123
Details
Following up on the changes mentioned #2015 (review)
Tested On
Internal Code changes thus no screenshots.