Remove timezone migration#2115
Merged
Merged
Conversation
roryabraham
approved these changes
Mar 26, 2021
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
Okay, LGTM. This PR is essentially just a revert of https://github.com/Expensify/Expensify.cash/pull/2040/files
85 tasks
Contributor
Author
|
For some reason I am unable to record my screen at the moment but I can confirm that this works on staging |
Contributor
Author
|
Got screen recording working 🎉 Screen.Recording.2021-03-26.at.2.41.51.PM.mov |
|
Nice! Need me to test it on my side too? |
Contributor
Author
|
Can't hurt 😅 I'd rather be safe than sorry here |
|
Contributor
|
@isagoico While that's not good, it looks to me like you're using the production website |
|
Yep I think the production "set up password" link is broken. I also updated on the staging results for this one here #2040 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
Removes a migration that was causing issues in the following PR: #2040
Fixed Issues
Fixes https://github.com//pull/2040#issuecomment-808354538Tests/QA
myPersonalDetailsmyPersonalDetailsso that it's a string like soOLD
NEW
Tested On
Screenshots
N/A no UI changes