Update expensify-common hash#2144
Merged
Merged
Conversation
Dal-Papa
previously approved these changes
Mar 30, 2021
Dal-Papa
left a comment
Dal-Papa
left a comment
There was a problem hiding this comment.
Something with the iOS E2E tests is failing, otherwise LGTM.
alex-mechler
dismissed stale reviews from Dal-Papa and nickmurray47
via
a691d86
Contributor
Author
|
Had to update the hash, so updated! |
Dal-Papa
approved these changes
Mar 31, 2021
Contributor
Author
|
Going to self merge since Nick approved the changes before, and its only a hash update. |
85 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nickmurray47 since you reviewed the expensify-common one
Details
Updates the expensify-common hash to fix a few expensimark bugs
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/153365
Fixes https://github.com/Expensify/Expensify/issues/156476
Tests / QA Steps
Mobile does not support wrapping code in some other tags, have an issue here. When these comments are created on mobile and viewed on web / desktop, they work correctly
Tested On
Screenshots
In tests