Focus the composer again after going back from a report not found by ginsuma · Pull Request #21962 · Expensify/App

ginsuma · 2023-06-30T16:34:42Z

Details

Compose box loses focus on coming back from 'Hmm... its not here' page.

Fixed Issues

$ #21678
PROPOSAL: #21678 (comment)

Tests

Open the app
Open any report
Copy report URL and paste in compose box
Add few numbers to it to make it invalid and send
Click on the link, it should open 'Hmm...it's not here' page
Click on back to observe that app does not focus back on compose box

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Safari

ios_safari.mov

Mobile Web - Chrome

android_chrome.mov

Desktop

desktop.mov

iOS

ios_app.mov

Android

android_app.mov

melvin-bot · 2023-06-30T16:34:48Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-07-03T09:08:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

web2.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

Julesssss · 2023-07-03T12:43:16Z

+        this.unsubscribeNavFocus = this.props.navigation.addListener('focus', () => {
+            if (this.willBlurTextInputOnTapOutside && !this.props.isFocused && !this.props.modal.isVisible) {
+                this.focus();


Why disable the eslint check? Can we instead follow its instructions and return if the inverse of the condition is true?

I agree, just updated.

narefyev91 · 2023-07-04T12:17:02Z

Friendly ping @Julesssss

OSBotify · 2023-07-04T13:23:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-05T17:31:35Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss · 2023-07-06T16:13:16Z

+            if (!this.willBlurTextInputOnTapOutside || this.props.isFocused || this.props.modal.isVisible) {
+                return;
+            }
+            this.focus();


This is a bit of a random guess, but I'm seeing a new crash associated and I'm curious if:

It's possible this change is the cause

Or maybe this exception simply occurred during testing? (do you have a Pixel 5 by any chance?)

Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError: Cannot read property 'focus' of null at .anonymous(address at index.android.bundle:1:2694129) at .apply((native):0:0) at .anonymous(address at index.android.bundle:1:237083) at ._callTimer(address at index.android.bundle:1:236365) at .callTimers(address at index.android.bundle:1:238167) at .apply((native):0:0) at .__callFunction(address at index.android.bundle:1:140250) at .anonymous(address at index.android.bundle:1:138615) at .__guard(address at index.android.bundle:1:139568) at .callFunctionReturnFlushedQueue(address at index.android.bundle:1:138573)

@ginsuma & @narefyev91

How can I reprocedue it? Or source map?

this is pretty strange - because we have all needed conditions to not get situation when this.textinput will null and we will try to focus

Yeah, I could be wrong here. This was just the only loc that contained a focus() call since yesterdays build.

How can I reprocedue it? Or source map?

I'm afraid we can't. That's why this is a bit of a random guess. If we don't think this was the cause then no further action is necessary 👍

OSBotify · 2023-07-07T10:37:01Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ginsuma · 2023-07-09T16:19:54Z

Currently I see we removed back button on header when opening a non-exist report but we still need this PR when clicking back on browser.
I want to make the code cleaner. Can I make a new PR?
cc: @narefyev91 @Julesssss

I will combine here and here to:

componentDidUpdate(prevProps) {
  ...
  if (this.willBlurTextInputOnTapOutside && this.props.isFocused && !this.props.modal.isVisible && (prevProps.modal.isVisible || !prevProps.isFocused)) {
    this.focus();
  }
  ...
}

Julesssss · 2023-07-10T11:15:28Z

Hi @ginsuma, sure. If you create a PR please mention this issue

Focus the composer again after going back from a report not found

a58fa1d

ginsuma requested a review from a team as a code owner June 30, 2023 16:34

melvin-bot Bot requested review from narefyev91 and removed request for a team June 30, 2023 16:34

ginsuma mentioned this pull request Jul 1, 2023

[HOLD for payment 2023-07-14] [$1000] Compose box loses focus on coming back from 'Hmm... its not here' page #21678

Closed

6 tasks

narefyev91 approved these changes Jul 3, 2023

View reviewed changes

melvin-bot Bot requested a review from Julesssss July 3, 2023 12:30

Julesssss assigned ginsuma Jul 3, 2023

Julesssss reviewed Jul 3, 2023

View reviewed changes

ginsuma added 2 commits July 3, 2023 20:01

Invert the condition

525034d

Invert the condition

294df97

ginsuma mentioned this pull request Jul 3, 2023

[HOLD for payment 2023-08-02] [$1000] App does not focus on compose box on mark as read/unread when we visit other profile and get back #21739

Closed

6 tasks

Julesssss approved these changes Jul 4, 2023

View reviewed changes

Julesssss merged commit 900b328 into Expensify:main Jul 4, 2023

OSBotify mentioned this pull request Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

Julesssss reviewed Jul 6, 2023

View reviewed changes

Julesssss mentioned this pull request Jul 10, 2023

[Awaiting Miro] [$1000] [HOLD for payment 2023-07-20] Minor ReportActionCompose code clean up #22547

Closed

ginsuma mentioned this pull request Jul 10, 2023

Minor ReportActionComposer code clean up #22550

Merged

57 tasks

Conversation

ginsuma commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 30, 2023

Uh oh!

narefyev91 commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

ginsuma Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Jul 4, 2023

Uh oh!

OSBotify commented Jul 4, 2023

Uh oh!

OSBotify commented Jul 5, 2023

Uh oh!

Julesssss Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

ginsuma Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narefyev91 Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

Julesssss Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

Julesssss Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 7, 2023

Uh oh!

ginsuma commented Jul 9, 2023

Uh oh!

Julesssss commented Jul 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ginsuma commented Jun 30, 2023 •

edited

Loading

narefyev91 commented Jul 3, 2023 •

edited

Loading

Julesssss Jul 6, 2023 •

edited

Loading

ginsuma Jul 6, 2023 •

edited

Loading