Fix app refocuses on compose box even when RHN is open if we right click on emoji reaction and click on user by hoangzinh · Pull Request #22107 · Expensify/App

hoangzinh · 2023-07-03T13:29:39Z

Details

Fixed Issues

$ #21526
PROPOSAL: #21526 (comment)

Tests

On Web/Desktop

Open the app
Open any report
React on any message with any emoji
Focus on compose box
Right click on emoji reaction and click on user in popup to open details page
Verify that the compose box is NOT focused, user can not send any message when RHN is open
Close the RHN
Focus on compose box
Left click on emoji reaction
Verify that the compose box is still focused

On mWeb/Native apps

Open the app
Open any report
React on any message with any emoji
Focus on compose box
Touch/press on emoji reaction
Verify that the compose box is still focused

Verify that no errors appear in the JS console

Offline tests

The fix is not related to network

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome:
https://github.com/Expensify/App/assets/9639873/9c585a80-f6aa-477d-bebb-d35bdf223d2d

Safari:

Screen.Recording.2023-07-03.at.21.07.31.-.web.safari.mov

Mobile Web - Chrome

Screen.Recording.2023-07-03.at.20.39.32.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-07-03.at.20.58.50.-.ios.safari.mov

Desktop

Screen.Recording.2023-07-03.at.20.38.02.-.desktop.mov

iOS

Screen.Recording.2023-07-03.at.20.58.18.-.ios.mov

Android

Screen.Recording.2023-07-03.at.21.00.04.-.android.mov

melvin-bot · 2023-07-03T14:08:58Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-07-03T15:17:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-04.at.4.30.25.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-04.at.4.53.31.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-04.at.4.52.44.PM.mov

Desktop

Screen.Recording.2023-07-04.at.4.32.05.PM.mov

iOS

Screen.Recording.2023-07-04.at.4.55.29.PM.mov

Android

Screen.Recording.2023-07-04.at.4.56.11.PM.mov

allroundexperts · 2023-07-04T10:09:24Z

@hoangzinh The composer does not get refocused if you don't open the RHN and just close the menu. I think this is a bug.

Screen.Recording.2023-07-04.at.3.08.06.PM.mov

hoangzinh · 2023-07-04T11:13:10Z

The composer does not get refocused if you don't open the RHN and just close the menu. I think this is a bug.

In your recording video above, that's a left click, so left click or touch will focus back to composer if we close/cancel it. In this case, we right click. I think it's align when we right click on the report action => it opens the context menu, but when we click outside, it doesn't focus to composer.

allroundexperts · 2023-07-04T11:15:47Z

The composer does not get refocused if you don't open the RHN and just close the menu. I think this is a bug.

In your recording video above, that's a left click, so left click or touch will focus back to composer if we close/cancel it. In this case, we right click. I think it's align when we right click on the report action => it opens the context menu, but when we click outside, it doesn't focus to composer.

You're actually correct on this. Thanks for the explanation!

allroundexperts · 2023-07-04T12:00:55Z

@hoangzinh I'm getting this in-consistent behaviour between iOS web and android web. Can you check?

Screen.Recording.2023-07-04.at.4.52.44.PM.mov

Screen.Recording.2023-07-04.at.4.53.31.PM.mov

allroundexperts · 2023-07-04T12:06:32Z

Update: I verified that this also happens on staging. @hoangzinh Can you confirm as well?

hoangzinh · 2023-07-04T12:41:13Z

Update: I verified that this also happens on staging. @hoangzinh Can you confirm as well?

Yes, I can confirm as well. That's why I have to proposal separate Tests in mweb/native app. Because I'm unsure which one is correct or is it a known issue.

allroundexperts · 2023-07-04T12:45:04Z

Yes, I can confirm as well. That's why I have to proposal separate Tests in mweb/native app. Because I'm unsure which one is correct or is it a known issue.

Can you create a bug report for this in Slack if it does not already exist?

allroundexperts

Looks good to me. Couple of in-consistencies found on mobile web, which we've verified, are happening on staging as well. @hoangzinh will create bug report.

allroundexperts · 2023-07-04T12:58:29Z

-            onMouseDown={(e) => e.preventDefault()}
+            onMouseDown={(e) => {
+                // Allow text input blur when emoji reaction is right clicked
+                if (e && e.button === 2) {


@hoangzinh NAB: Can you point me to the documentation of e.button property? My understanding was that we'd be using e.nativeEvent.which prop.

Yeah, e.which is deprecated. So I use e.button which is also popular used https://caniuse.com/mdn-api_mouseevent_buttons. I also recorded in both Chrome and Safari and attach in the PR description

Excellent. Thank you!

OSBotify · 2023-07-04T17:19:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-05T17:31:20Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-07T10:36:46Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

hoangzinh added 2 commits July 3, 2023 20:22

Allow text input blur when right click on emoji reaction

0d0b98f

Update comment

fba2e7e

hoangzinh marked this pull request as ready for review July 3, 2023 14:08

hoangzinh requested a review from a team as a code owner July 3, 2023 14:08

melvin-bot Bot requested review from allroundexperts and removed request for a team July 3, 2023 14:08

hoangzinh mentioned this pull request Jul 3, 2023

[HOLD for payment 2023-07-14] [$1000] App refocuses on compose box even when RHN is open if we right click on emoji reaction and click on user #21526

Closed

6 tasks

allroundexperts approved these changes Jul 4, 2023

View reviewed changes

melvin-bot Bot requested a review from madmax330 July 4, 2023 12:46

allroundexperts reviewed Jul 4, 2023

View reviewed changes

madmax330 approved these changes Jul 4, 2023

View reviewed changes

madmax330 merged commit b2556be into Expensify:main Jul 4, 2023

OSBotify mentioned this pull request Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

paultsimura mentioned this pull request Sep 12, 2023

Web - Unable to type when popover is open from emoji reaction #27250

Closed

6 tasks

mkhutornyi mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-18] [$500] Web - Chat - Able to type in composer while popover is open #25485

Closed

6 tasks

Conversation

hoangzinh commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 3, 2023

Uh oh!

allroundexperts commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Jul 4, 2023

Uh oh!

hoangzinh commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Jul 4, 2023

Uh oh!

allroundexperts commented Jul 4, 2023

Uh oh!

allroundexperts commented Jul 4, 2023

Uh oh!

hoangzinh commented Jul 4, 2023

Uh oh!

allroundexperts commented Jul 4, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jul 4, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jul 4, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jul 4, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 4, 2023

Uh oh!

OSBotify commented Jul 5, 2023

Uh oh!

OSBotify commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hoangzinh commented Jul 3, 2023 •

edited

Loading

allroundexperts commented Jul 3, 2023 •

edited

Loading

hoangzinh commented Jul 4, 2023 •

edited

Loading