fix "Android - Keyboard doesn't open automatically while verifying contact method by situchan · Pull Request #22164 · Expensify/App

situchan · 2023-07-04T11:13:25Z

Details

android delay autofocus in verify contact method
fix shouldDelayFocus logic in MagicCodeInput component

Fixed Issues

$ #21415
PROPOSAL: #21415 (comment)

Tests

Same as QA step

Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

Login any account
Go to Settings > Profile > Contact method
Add new contact method
Now click the recently added contact method to verify
Verify that magic code input is focused automatically and keyboard shows

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

login:

web.mov

Mobile Web - Chrome

mchrome.mov

login:

mchrome.mov

Mobile Web - Safari

msafari.mov

login:

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

login:

ios.mov

Android

android.mov

login:

android.mov

…ntact method"

melvin-bot · 2023-07-04T11:13:30Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-07-04T12:20:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-05.at.10.40.21.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-05.at.10.42.40.AM.mov

Mobile Web - Safari

Screen.Recording.2023-07-05.at.11.02.17.AM.mov

Desktop

Screen.Recording.2023-07-05.at.11.06.00.AM.mov

iOS

Screen.Recording.2023-07-05.at.10.39.44.AM.mov

Android

Screen.Recording.2023-07-05.at.10.38.49.AM.mov

allroundexperts · 2023-07-05T06:29:52Z

@situchan The following case does not seem to work:
https://github.com/Expensify/App/assets/30054992/6f0c974a-c66f-494a-8942-b43eb0554156

allroundexperts · 2023-07-05T06:44:00Z

+        // We only want this to run on mount
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);


What happens if we keep those props?

This is aligned with BaseTextInput.
No issue with original dependencies but no need, as auto-focus should happen only on component mount.

Sounds good. Can you also upload screen recordings of the magic code input on the login page working as expected?

Done.

Note: mSafari login magic code auto-focus doesn't work on main

@situchan It's working on Staging.

Screen.Recording.2023-07-05.at.3.08.34.PM.mov

Not working for me. Tested on iOS 16.4. Might depend on iOS version.

Screen.Recording.2023-07-05.at.11.20.17.AM.mov

It would be great if you can test this branch on your simulator.
As shouldDelayFocus is not passed to MagicCodeInput on sign in page, it should not be affected by this PR.

I guess it has do with the iOS version. Just tested locally and it works!

Proof:
https://github.com/Expensify/App/assets/30054992/7720196c-a696-454f-8e73-a5b1a795ce7a

situchan · 2023-07-05T09:05:55Z

@situchan The following case does not seem to work: https://github.com/Expensify/App/assets/30054992/6f0c974a-c66f-494a-8942-b43eb0554156

I don't see any other pages which auto-focus and show keyboard after reload on mChrome.
i.e. login magic code input, new room, new chat/group

…/21415-verify-contact-method-autofocus

allroundexperts

Working good!

techievivek

Looks good to me.

OSBotify · 2023-07-06T02:56:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-07T10:45:24Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-11T00:00:26Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix "Android - Keyboard doesn't open automatically while verifying co…

ca4fcaf

…ntact method"

situchan requested a review from a team as a code owner July 4, 2023 11:13

melvin-bot Bot requested review from allroundexperts and removed request for a team July 4, 2023 11:13

situchan mentioned this pull request Jul 4, 2023

[HOLD for payment 2023-07-17] [$1000] Android - Keyboard doesn't open automatically while verifying contact method #21415

Closed

6 tasks

allroundexperts reviewed Jul 5, 2023

View reviewed changes

Merge branch 'main' of https://github.com/situchan/Expensify into fix…

4115925

…/21415-verify-contact-method-autofocus

allroundexperts approved these changes Jul 5, 2023

View reviewed changes

melvin-bot Bot requested a review from techievivek July 5, 2023 12:26

techievivek approved these changes Jul 6, 2023

View reviewed changes

techievivek merged commit b183c41 into Expensify:main Jul 6, 2023

huzaifa-99 mentioned this pull request Jul 6, 2023

Removed isVisible prop from ValidateCodeForm #21594

Merged

57 tasks

OSBotify mentioned this pull request Jul 7, 2023

Deploy Checklist: New Expensify 2023-07-07 #22399

Closed

64 tasks

situchan deleted the fix/21415-verify-contact-method-autofocus branch November 4, 2025 03:19

Conversation

situchan commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 4, 2023

Uh oh!

allroundexperts commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Jul 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Jul 5, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 6, 2023

Uh oh!

OSBotify commented Jul 7, 2023

Uh oh!

OSBotify commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

situchan commented Jul 4, 2023 •

edited

Loading

allroundexperts commented Jul 4, 2023 •

edited

Loading