Skip to content

Show visible tooltip after animation cancel #22249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertjchen merged 2 commits into from
Jul 5, 2023
Merged

Show visible tooltip after animation cancel #22249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0adc288
show visible tooltip after animation cancel
huzaifa-99 Jul 5, 2023
9ea2f1e
Fix lint
huzaifa-99 Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/components/Tooltip/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ class Tooltip extends PureComponent {
this.showTooltip = this.showTooltip.bind(this);
this.hideTooltip = this.hideTooltip.bind(this);
this.updateBounds = this.updateBounds.bind(this);
this.isAnimationCanceled = React.createRef(false);
}

// eslint-disable-next-line rulesdir/prefer-early-return
componentDidUpdate(prevProps) {
// if the tooltip text changed before the initial animation was finished, then the tooltip won't be shown
// we need to show the tooltip again
if (this.state.isVisible && this.isAnimationCanceled.current && this.props.text && prevProps.text !== this.props.text) {
this.isAnimationCanceled.current = false;
this.showTooltip();
}
}

/**
Expand Down Expand Up @@ -86,7 +97,9 @@ class Tooltip extends PureComponent {
duration: 140,
delay: 500,
useNativeDriver: false,
}).start();
}).start(({finished}) => {
this.isAnimationCanceled.current = !finished;
});
}
TooltipSense.activate();
}
Expand Down