[No QA] Remove the ReportActionContextMenu beta#2234
Merged
Conversation
Jag96
suggested changes
Apr 5, 2021
Jag96
left a comment
Jag96
left a comment
Contributor
There was a problem hiding this comment.
When running this on web I get an error, looks like there's still 2 usages of isInReportActionContextMenuBeta
ReportActionItem.js:101 Uncaught TypeError: _this2.isInReportActionContextMenuBeta is not a function
| * @returns {Boolean} | ||
| */ | ||
| isInReportActionContextMenuBeta() { | ||
| return _.contains(this.props.betas, CONST.BETAS.REPORT_ACTION_CONTEXT_MENU) |
Contributor
There was a problem hiding this comment.
Do we still need this beta constant? It looks like its unused now
Contributor
Author
|
Updated! |
yuwenmemon
approved these changes
Apr 6, 2021
Jag96
approved these changes
Apr 6, 2021
85 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Coming from this Slack thread
Tests (Web/Desktop)
reportActionContextMenuappears (it's just one lonely clipboard icon) now 😭Tests (iOS/Android/mWeb)
QA Steps
The "Copy Comment" functionality is covered by regression testing, so we shouldn't need any extra QA here.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android