Fix a few things about tasks from the redesign by jasperhuangg · Pull Request #22586 · Expensify/App

jasperhuangg · 2023-07-10T20:03:55Z

Details

This didn't happen on staging or production, but for whatever reason the dev build of RN makes it so that multiline text inputs don't focus to the end. This PR fixes that.
Makes it so the task title input in task creation accepts multiple lines
Makes it so clicking the task header doesn't open the task assignee selector modal. Instead it now functions like threads, navigating you back to the parent report.

Fixed Issues

$ #22494
$ #22495
$ #22498

Tests/QA

FAB > Assign Task.
Enter a large amount of text into the task title This is a very very long task title that should occupy multiple lines, at the very least., verify that it can occupies multiple lines.
Finish creating the task with any other values for the other fields.
In the Task View, click the title. Verify that the cursor is at the end of the text input.
Close the task title modal. Click the header. Verify it takes you back to the task's parent report, and doesn't open the task assignee selector modal.

PR Author Checklist

Screenshots/Videos

Had some issues with Android/iOS simulators, but was able to test on them prior and confirmed they were working

Web

web.mov

Mobile Web - Chrome

mweb_chrome.mov

Mobile Web - Safari

mweb_safari.mp4

Desktop

desktop.mov

iOS

Android

melvin-bot · 2023-07-10T20:13:47Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-07-10T21:15:28Z

@jasperhuangg Conflicts please resolve

jasperhuangg · 2023-07-10T21:38:53Z

@Santhosh-Sellavel had to incorporate a few more changes into this PR, give me a moment while I update the screen recordings

thienlnam

Appreciate the PR, thanks for fixing these things!

jasperhuangg · 2023-07-10T23:48:32Z

@Santhosh-Sellavel this is ready for review!

chiragxarora · 2023-07-11T06:27:35Z

@jasperhuangg I believe this bug here #22516 talks about this thing, we are not translating it

App/src/components/ReportActionItem/TaskView.js

Line 68 in 882026d

<Text style={styles.taskTitleDescription}>Title</Text>

Santhosh-Sellavel · 2023-07-11T17:04:31Z

@jasperhuangg Are you gonna handle this or not?

jasperhuangg · 2023-07-11T18:50:44Z

@Santhosh-Sellavel fixed!

thienlnam · 2023-07-11T20:11:59Z

                    <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]}>
                        <PressableWithoutFeedback
-                            onPress={() => (isTaskReport ? Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID)) : ReportUtils.navigateToDetailsPage(props.report))}
+                            onPress={() => !isTaskReport && ReportUtils.navigateToDetailsPage(props.report)}


You can remove the !isTaskReport && here

jasperhuangg · 2023-07-12T18:59:28Z

@Santhosh-Sellavel are you able to help review this?

Santhosh-Sellavel · 2023-07-12T19:07:38Z

Yes, I'm running into weird issues. Keep getting these warnings.

Santhosh-Sellavel · 2023-07-12T19:40:47Z

@jasperhuangg

I'm getting redirected to this not found page.

Steps:

FAB > Assign Task
Enter a large amount of text into the task title This is a very very long task title that should occupy multiple lines, at the very least., verify that it can occupies multiple lines.
Finish creating the task with any other values for the other fields.
After a few seconds not found error page is shown

Screen.Recording.2023-07-13.at.1.13.26.AM.mov

jasperhuangg · 2023-07-13T00:54:08Z

@Santhosh-Sellavel few questions in your Slack DM, I am unable to reproduce that issue but wanted to clarify some things. I don't believe those problems are related to the changes in my PR, and would be curious for you to try the exact same flow/accounts but on main to see if those issues still happen.

Santhosh-Sellavel · 2023-07-14T13:56:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-14.at.7.19.01.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-07-14.at.7.19.44.PM.mov

Desktop

Screen.Recording.2023-07-14.at.7.18.06.PM.mov

iOS & Android

Screen.Recording.2023-07-14.at.7.22.05.PM.mov

Santhosh-Sellavel · 2023-07-14T15:34:10Z

All looks good. Just a couple of questions.

While online, click the header near the subtitle that has the text from some email and take to the report where the task was shared. And click the task title in the header takes you to the details page of the chat where it was shared. Is it the expected behavior?
While offline, after performing the steps in the test create a new task. When I click the from some email takes me to the chat as it was shared. But when clicking on the task name in the header takes me to the details page and it is empty. Is it expected or what should we do now?

Refer video for more understanding, can you answer those questions please thanks!

Screen.Recording.2023-07-14.at.8.54.56.PM.mov

jasperhuangg · 2023-07-14T16:52:34Z

All looks good. Just a couple of questions.

While online, click the header near the subtitle that has the text from some email and take to the report where the task was shared. And click the task title in the header takes you to the details page of the chat where it was shared. Is it the expected behavior?

While offline, after performing the steps in the test create a new task. When I click the from some email takes me to the chat as it was shared. But when clicking on the task name in the header takes me to the details page and it is empty. Is it expected or what should we do now?

Refer video for more understanding, can you answer those questions please thanks!

Screen.Recording.2023-07-14.at.8.54.56.PM.mov

Yes that's expected
I’m honestly not sure, I don't think that's expected? But this bug seems like it has to do with an existing issue that's we're fixing internally, so I wouldn't worry about it.

Santhosh-Sellavel · 2023-07-14T17:03:42Z

But this bug seems like it has to do with an existing issue that's we're fixing internally, so I wouldn't worry about it.

Should I report it then?

jasperhuangg · 2023-07-14T17:09:40Z

@Santhosh-Sellavel Ill keep it in mind, but I don't think we need to report it. I'll see if that other issue solves it first before doing anything here.

Santhosh-Sellavel

LGTM tests well!
C+ Reviewed
🎀 👀 🎀

melvin-bot · 2023-07-14T17:11:59Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam

Going to go ahead and handle the review for this since I've been following along

OSBotify · 2023-07-14T18:29:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-17T19:38:56Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-19T18:00:41Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ensure task title page focuses is at the end on dev

dd99fd3

jasperhuangg self-assigned this Jul 10, 2023

jasperhuangg marked this pull request as ready for review July 10, 2023 20:13

jasperhuangg requested a review from a team as a code owner July 10, 2023 20:13

melvin-bot Bot requested review from Santhosh-Sellavel and removed request for a team July 10, 2023 20:13

jasperhuangg mentioned this pull request Jul 10, 2023

[HOLD for payment 2023-07-20] Task Detailed View Redesign #19330

Closed

jasperhuangg changed the title ~~Ensure task title page text input cursor is at the end on dev~~ Fix a few minor tasks bugs from the redesign Jul 10, 2023

jasperhuangg marked this pull request as draft July 10, 2023 21:21

jasperhuangg changed the title ~~Fix a few minor tasks bugs from the redesign~~ Fix a few things about tasks from the redesign Jul 10, 2023

jasperhuangg added 2 commits July 10, 2023 14:30

ensure task title input occupies multiple lines

c6ad06e

don't open task assignee selector modal when clicking task headers

60deb79

jasperhuangg requested a review from thienlnam July 10, 2023 21:30

resolve conflicts

8207edc

thienlnam reviewed Jul 10, 2023

View reviewed changes

jasperhuangg marked this pull request as ready for review July 10, 2023 22:07

jasperhuangg requested a review from thienlnam July 11, 2023 02:35

use default language for title

7ad293e

remove unused

76704c4

thienlnam mentioned this pull request Jul 11, 2023

Assign task - The word title is not translated into Spanish in chat #22684

Closed

6 tasks

thienlnam suggested changes Jul 11, 2023

View reviewed changes

Navigate to details page for task reports upon clicking header

1bd5f0d

jasperhuangg requested a review from thienlnam July 11, 2023 20:19

dhairyasenjaliya mentioned this pull request Jul 13, 2023

[$1000] Dev : On task view page header Title is not translated on Spanish #22516

Closed

6 tasks

Santhosh-Sellavel approved these changes Jul 14, 2023

View reviewed changes

melvin-bot Bot requested a review from AndrewGable July 14, 2023 17:11

thienlnam approved these changes Jul 14, 2023

View reviewed changes

thienlnam merged commit 5f051cd into main Jul 14, 2023

thienlnam deleted the jasper-fixTaskTitleFocus branch July 14, 2023 18:26

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

lanitochka17 mentioned this pull request Jul 18, 2023

Task - The cursor isn’t appeared at the end of the text input on title #23049

Closed

6 tasks

danieldoglas mentioned this pull request Jul 18, 2023

[HOLD for payment 2023-08-02] [$1000] The cursor position is not at the end of the message when editing the welcome message #21523

Closed

6 tasks

ayazhussain79 mentioned this pull request Jul 18, 2023

[HOLD for payment 2023-07-26] Dev: Web - Cursor position is not at the end of the task title #22494

Closed

6 tasks

Nikhil-Vats mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-08-03] [$1000] You can add newlines in task titles #23025

Closed

6 tasks

Santhosh-Sellavel mentioned this pull request Jul 20, 2023

[HOLD for payment 2023-08-24] [$1000] Web - Task Detail screen is empty #23296

Closed

6 tasks

jasperhuangg mentioned this pull request Jul 20, 2023

[Awaiting payment in ND] [HOLD for payment 07-26-2023] Tracking issue for payment #23314

Closed

Nodebrute mentioned this pull request Jul 26, 2023

[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

Closed

6 tasks

Conversation

jasperhuangg commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests/QA

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 10, 2023

Uh oh!

Santhosh-Sellavel commented Jul 10, 2023

Uh oh!

jasperhuangg commented Jul 10, 2023

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Jul 10, 2023

Uh oh!

chiragxarora commented Jul 11, 2023

Uh oh!

Santhosh-Sellavel commented Jul 11, 2023

Uh oh!

jasperhuangg commented Jul 11, 2023

Uh oh!

thienlnam Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Jul 12, 2023

Uh oh!

Santhosh-Sellavel commented Jul 12, 2023

Uh oh!

Santhosh-Sellavel commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasperhuangg commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasperhuangg commented Jul 14, 2023

Uh oh!

Santhosh-Sellavel commented Jul 14, 2023

Uh oh!

jasperhuangg commented Jul 14, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 14, 2023

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 14, 2023

Uh oh!

OSBotify commented Jul 17, 2023

Uh oh!

OSBotify commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jasperhuangg commented Jul 10, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 12, 2023 •

edited

Loading

jasperhuangg commented Jul 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 14, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 14, 2023 •

edited

Loading