Skip to content

Change GSD to focus#2273

Merged
roryabraham merged 1 commit into
masterfrom
Rory-GSDToFocus
Apr 7, 2021
Merged

Change GSD to focus#2273
roryabraham merged 1 commit into
masterfrom
Rory-GSDToFocus

Conversation

@roryabraham

@roryabraham roryabraham commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

Details

We need to change "Get Shit Done" to "#focus" to prevent our app from being rejected by the app stores due to illicit language.

Fixed Issues

Slack discussion here

Tests / QA Steps

  1. Open the preferences page
  2. Change the priority mode, make sure you see #focus and not GSD in the drop-down.
  3. The description beneath should not include the word "shit".

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

image

Desktop

image

iOS

image

image

Android

image
image

@roryabraham roryabraham requested a review from a team as a code owner April 7, 2021 17:09
@roryabraham roryabraham self-assigned this Apr 7, 2021
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team April 7, 2021 17:10
@roryabraham

Copy link
Copy Markdown
Contributor Author

Merging to unblock android deploys

@roryabraham roryabraham merged commit 11488ec into master Apr 7, 2021
@roryabraham roryabraham deleted the Rory-GSDToFocus branch April 7, 2021 17:19
@botify

botify commented Apr 7, 2021

Copy link
Copy Markdown

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants