[CP Staging] [NoQA] Bump the onyx version to loosen mergeCollection by mountiny · Pull Request #22782 · Expensify/App

mountiny · 2023-07-13T00:08:48Z

Details

Follow up to Expensify/react-native-onyx#272, when mergeCollection keys in the onyx updates queue are malformed, it will block the entire queue, this change will discard such malformed update and allows the app to work normally after that.

cc @luacmartins @PauloGasparSv

Fixed Issues

$ #22853
Related to https://expensify.slack.com/archives/C049HHMV9SM/p1689120594593919

Tests

Verify that no errors appear in the JS console

use account which does have some old requests and transactions
try to visit various pages
make sure they load
Verify you dont see error similar to this one in the console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Including web screenshots only as thats the main platform we can test the console errors

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-13T00:08:53Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-07-13T13:55:11Z

Reviewing it now

PauloGasparSv · 2023-07-13T13:57:12Z

Reviewing it now

Same here!

Btw, we can also manually store that mal-formated data by going to the console and running

Onyx.merge('queuedOnyxUpdates', [
  {
    "onyxMethod": "mergecollection",
    "key": "transactions_1282450064524658",
    "value": {
      "2463815779269125254": {
        "amount": 3000,
        "comment": { "comment": "" },
        "created": "2023-06-28 16:28:44",
        "currency": "USD",
        "modifiedAmount": 0,
        "modifiedCreated": "",
        "modifiedCurrency": "",
        "transactionID": "2463815779269125254"
      },
    }
  }
]);

Running that on main (without this fix):

Santhosh-Sellavel · 2023-07-13T14:09:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-13.at.7.56.07.PM.mov

Mobile Web - Chrome && Mobile Web - Safari

Desktop

Screen.Recording.2023-07-13.at.7.57.16.PM.mov

iOS & Android

PauloGasparSv

LGTM!

The error is now logged instead of thrown and only once as expected

Santhosh-Sellavel · 2023-07-13T14:25:47Z

@mountiny Old transaction details are not loading.

Screen.Recording.2023-07-13.at.7.54.11.PM.mov

mountiny · 2023-07-13T15:08:49Z

Is this happening on main as well? I dont think this should be related

mountiny · 2023-07-13T15:20:34Z

I can repro on main so this is not related

Santhosh-Sellavel · 2023-07-13T15:42:46Z

Okay, Cool then. I played around with the app and didn't see the error mentioned.

Santhosh-Sellavel

LGTM, tests well!

melvin-bot · 2023-07-13T15:56:39Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-07-13T16:13:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[NoQA] Bump the onyx version to loosen mergeCollection (cherry picked from commit 3c35be1)

OSBotify · 2023-07-13T16:58:09Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.40-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-14T14:43:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:40:35Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-19T18:02:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Bump the onyx version to loosen mergecollection

f0388c8

mountiny requested a review from a team as a code owner July 13, 2023 00:08

mountiny self-assigned this Jul 13, 2023

melvin-bot Bot requested review from Santhosh-Sellavel and removed request for a team July 13, 2023 00:08

mountiny requested a review from PauloGasparSv July 13, 2023 00:13

luacmartins previously approved these changes Jul 13, 2023

View reviewed changes

Resolve merge conflicts

be08435

mountiny dismissed luacmartins’s stale review via be08435 July 13, 2023 00:17

luacmartins approved these changes Jul 13, 2023

View reviewed changes

PauloGasparSv approved these changes Jul 13, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Jul 13, 2023

View reviewed changes

melvin-bot Bot requested a review from thienlnam July 13, 2023 15:56

luacmartins merged commit 3c35be1 into main Jul 13, 2023

luacmartins deleted the vit-bumpOnyxVersion branch July 13, 2023 16:03

OSBotify pushed a commit that referenced this pull request Jul 13, 2023

Merge pull request #22782 from Expensify/vit-bumpOnyxVersion

33a6306

[NoQA] Bump the onyx version to loosen mergeCollection (cherry picked from commit 3c35be1)

mountiny changed the title ~~[NoQA] Bump the onyx version to loosen mergeCollection~~ [CP Staging] [NoQA] Bump the onyx version to loosen mergeCollection Jul 13, 2023

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-13 #22783

Closed

53 tasks

melvin-bot Bot mentioned this pull request Jul 14, 2023

[HOLD for payment 2023-07-24] [HOLD for payment 2023-07-21] Transactions key console error on mergeCollection #22853

Closed

6 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

Conversation

mountiny commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 13, 2023

Uh oh!

Santhosh-Sellavel commented Jul 13, 2023

Uh oh!

PauloGasparSv commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

PauloGasparSv left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Jul 13, 2023

Uh oh!

mountiny commented Jul 13, 2023

Uh oh!

mountiny commented Jul 13, 2023

Uh oh!

Santhosh-Sellavel commented Jul 13, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 13, 2023

Uh oh!

OSBotify commented Jul 13, 2023

Uh oh!

OSBotify commented Jul 13, 2023

Uh oh!

OSBotify commented Jul 14, 2023

Uh oh!

OSBotify commented Jul 17, 2023

Uh oh!

OSBotify commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mountiny commented Jul 13, 2023 •

edited

Loading

PauloGasparSv commented Jul 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 13, 2023 •

edited

Loading