Add ability to dismiss attachment modal via swipe#2442
Merged
Conversation
Jag96
commented
Apr 16, 2021
| - React-Core | ||
| - RNCAsyncStorage (1.12.1): | ||
| - React-Core | ||
| - RNCClipboard (1.5.1): |
Contributor
Author
There was a problem hiding this comment.
Looks like this wasn't updated previously, doing a pod install added these.
66 tasks
Contributor
|
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
|
Android/iOS - Chat - Image does not zoom in when two fingers are used Expected ResultConfirm the image zooms in Actual ResultImage does not zoom in Action Performed
PlatformiOS ✔️ Notes/Images/Videos Bug5030887_20210420_162938_1_.mp4 |
Contributor
Author
|
@isagoico if this is happening on production then let's create a new issue for it, feel free to tag me in it and I'll have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcaaron will you please review this?
Details
This PR adds the ability to swipe down and right to dismiss an attachment on mobile.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/154788
Tests
QA Steps
Same as above
Tested On