Migrate index.native.js to function component by kadiealexander · Pull Request #24615 · Expensify/App

kadiealexander · 2023-08-16T07:47:52Z

Details

Fixed Issues

$ #16187
PROPOSAL:

Tests

Upload a password-protected PDF to an Expensify chat
Open the PDF
Click to enter the password
Enter the correct password
Verify the PDF appears
Close the PDF
Open the PDF
Click to enter the password
Enter an incorrect password
Verify that an incorrect password error occurs

Verify that no errors appear in the JS console

Offline tests

If you go offline once the PDF is uploaded, you should be able to still complete the steps above.

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-11-13_20-30-24.mp4

Mobile Web - Chrome

#24615 (comment)

Mobile Web - Safari

2023-11-07_20-00-34.mp4

Desktop

2023-11-07_20-01-29.mp4

iOS

2023-11-07_19-54-49.mp4

Android

#24615 (comment)

…ex-update

cloudflare-workers-and-pages · 2023-10-16T07:43:49Z

Deploying with Cloudflare Pages

Latest commit:	`3597be6`
Status:	✅ Deploy successful!
Preview URL:	https://14bcf6fc.helpdot.pages.dev
Branch Preview URL:	https://kadie-native-index-update.helpdot.pages.dev

View logs

This reverts commit 00efb24.

kadiealexander · 2023-10-17T03:08:45Z

@0xmiroslav @puneetlath I'd love your thoughts on this! When testing this, I get stuck in a "invalid password" loop even though I know my PDF password is valid. I don't get any console errors or anything to help me debug, it just declines my password every time. Could either of you take a look and see what might be causing this? 🙏 I'm at a loss!

0xmiroslav · 2023-10-17T07:12:07Z

No issue for me. Also tested this branch.
Can you try with this pdf? (password is 12345678)

test_pwd.pdf

kadiealexander · 2023-10-20T03:53:50Z

@0xmiroslav I'm still getting the "wrong password" error when using your PDF:

Are you also testing on iOS?

0xmiroslav · 2023-10-20T04:07:26Z

yes, iOS.
So you cannot reproduce on main but only on this branch?

kadiealexander · 2023-10-20T04:38:27Z

Yup, works fine on main!

kadiealexander · 2023-10-27T05:11:33Z

@puneetlath @0xmiroslav any thoughts on what might be causing this issue? Puneet, could you please try testing my branch and see if you run into the same issue?

…ex-update

kadiealexander · 2023-11-07T07:20:03Z

Fixed it! @0xmiroslav I'm not able to test on Android, my dev environment is busted. Are you please able to test on Android mWeb and Native for me?

0xmiroslav · 2023-11-07T07:21:08Z

Fixed it! @0xmiroslav I'm not able to test on Android, my dev environment is busted. Are you please able to test on Android mWeb and Native for me?

yes. Please mark ready for review when ready

0xmiroslav · 2024-01-18T05:32:59Z

kadiealexander · 2024-01-19T04:46:33Z

@0xmiroslav please review, hopefully for the last time!

Co-authored-by: 0xmiroslav <97473779+0xmiroslav@users.noreply.github.com>

0xmiroslav · 2024-01-19T06:04:46Z

@kadiealexander I got these console warnings because they're not removed in pdfViewPropTypes.js.
But they cannot be deprecated yet as they're still being used in PDFView/index.js as class component, which will be migrated to function in #31281 (I can review this as well if you want 🙂).

0xmiroslav · 2024-01-19T06:26:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

0xmiroslav

Looks good except these propTypes console warnings.
As they're dev only error, not blocker.

melvin-bot · 2024-01-19T06:28:32Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar

Working limited time this week. I'll be back to this shortly

melvin-bot · 2024-01-24T01:31:09Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mallenexpensify · 2024-01-24T01:31:21Z

#16187
@Santhosh-Sellavel reassigned the above, please review the PR.

Santhosh-Sellavel · 2024-01-24T19:22:27Z

@kadiealexander

Console errors in the recording below are introduced in this PR can you fix them please, thanks!
https://github.com/Expensify/App/assets/85645967/2bb9d0ac-f18b-4ec8-a686-c3984dc990c7

Santhosh-Sellavel

Check this out #24615 (comment)!

Santhosh-Sellavel · 2024-02-02T17:18:04Z

Any update @kadiealexander

kadiealexander · 2024-02-07T22:00:31Z

Hey @Santhosh-Sellavel, I think it's best if I remove withThemeStyles alongside this PR as opposed to including them in this PR. What are your thoughts on this?

Santhosh-Sellavel · 2024-02-12T14:55:14Z

Hey @Santhosh-Sellavel, I think it's best if I remove withThemeStyles alongside this PR as opposed to including them in this PR. What are your thoughts on this?

Somehow this got missed from my radar, yeah I agree we can merge this. Sorry I missed the fact that props are still required in web platforms
we need to ensure the errors are resolved in #31281

OSBotify · 2024-02-12T15:15:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:22:58Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Updated variables and states (WIP)

2a543a2

kadiealexander mentioned this pull request Aug 16, 2023

[$250] Migrate index.native.js to function component #16187

Closed

1 task

kadiealexander added 4 commits August 16, 2023 20:03

began updating lifecycle method to useEffect

0b36d7c

Merge branch 'main' of github.com:Expensify/App into kadie-native-ind…

3dcc675

…ex-update

latest useEffect updates

3834c8c

merge main

67b1555

kadiealexander added 6 commits October 17, 2023 10:14

Merge branch 'main' into kadie-native-index-update

aa23f3a

small errors found during testing

00efb24

trying to make lint happy

520b39d

Revert "small errors found during testing"

72f601d

This reverts commit 00efb24.

Revert "small errors found during testing"

437ebeb

This reverts commit 00efb24.

fix functions and run lint/prettier

3597be6

kadiealexander self-assigned this Oct 17, 2023

kadiealexander mentioned this pull request Oct 17, 2023

[HOLD #33434][$250] Migrate index.js to function component #16186

Closed

1 task

kadiealexander added 4 commits October 31, 2023 09:13

merging with main

6f892b6

Merge branch 'main' of github.com:Expensify/App into kadie-native-ind…

bffa142

…ex-update

ran prettier

b010ede

removed unnecessary PasswordResponses definition

c15f3d4

kadiealexander requested a review from 0xmiroslav November 13, 2023 07:41

kadiealexander marked this pull request as ready for review November 13, 2023 07:42

kadiealexander requested a review from a team as a code owner November 13, 2023 07:42

merging main

798861b

0xmiroslav reviewed Jan 19, 2024

View reviewed changes

Comment thread src/components/PDFView/index.native.js Outdated

kadiealexander requested a review from 0xmiroslav January 19, 2024 04:46

kadiealexander and others added 2 commits January 19, 2024 17:47

Update src/components/PDFView/index.native.js

347c1f5

Co-authored-by: 0xmiroslav <97473779+0xmiroslav@users.noreply.github.com>

running prettier

a74f76b

0xmiroslav approved these changes Jan 19, 2024

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar January 19, 2024 06:28

MonilBhavsar reviewed Jan 22, 2024

View reviewed changes

mallenexpensify requested a review from a team January 24, 2024 01:31

melvin-bot Bot requested review from Santhosh-Sellavel and removed request for a team January 24, 2024 01:31

Santhosh-Sellavel suggested changes Jan 24, 2024

View reviewed changes

puneetlath approved these changes Feb 12, 2024

View reviewed changes

puneetlath merged commit 19a0451 into main Feb 12, 2024

puneetlath deleted the kadie-native-index-update branch February 12, 2024 15:10

This was referenced Feb 12, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #36344

Closed

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

Conversation

kadiealexander commented Aug 16, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

cloudflare-workers-and-pages Bot commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

kadiealexander commented Oct 17, 2023

Uh oh!

0xmiroslav commented Oct 17, 2023

Uh oh!

kadiealexander commented Oct 20, 2023

Uh oh!

0xmiroslav commented Oct 20, 2023

Uh oh!

kadiealexander commented Oct 20, 2023

Uh oh!

kadiealexander commented Oct 27, 2023

Uh oh!

kadiealexander commented Nov 7, 2023

Uh oh!

0xmiroslav commented Nov 7, 2023

Uh oh!

0xmiroslav commented Jan 18, 2024

Uh oh!

Uh oh!

kadiealexander commented Jan 19, 2024

Uh oh!

0xmiroslav commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented Jan 19, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 19, 2024

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 24, 2024

Uh oh!

mallenexpensify commented Jan 24, 2024

Uh oh!

Santhosh-Sellavel commented Jan 24, 2024

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Feb 2, 2024

Uh oh!

kadiealexander commented Feb 7, 2024

Uh oh!

Santhosh-Sellavel commented Feb 12, 2024

Uh oh!

OSBotify commented Feb 12, 2024

Uh oh!

OSBotify commented Feb 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kadiealexander commented Aug 16, 2023 •

edited by github-actions Bot

Loading

cloudflare-workers-and-pages Bot commented Oct 16, 2023 •

edited

Loading

0xmiroslav commented Jan 19, 2024 •

edited

Loading