feat(26270): Add Skeleton UI for Money Requests by mananjadhav · Pull Request #26613 · Expensify/App

mananjadhav · 2023-09-03T18:25:27Z

Details

Adds the SkeletonView to the Money Requests, while the transaction is being loaded.

Fixed Issues

$ #26270
PROPOSAL:

Tests

Check the skeleton UI is loaded for the request money
Check the skeleton UI is loaded for the distance money request
Verify the skeleton UI design is as per this spec.
Verify the skeleton UI is hidden once the transaction is loaded.
Verify that no errors appear in the JS console

Offline tests

Skeleton UI won't be loaded in the offline mode, as we see greyed out amounts for the transaction.

QA Steps

For all platforms

Open the app, logout if you're already logged in. (this is to ensure that we don't load the transactions from local storage).
You can enable throttling with slow 3G/2G for the longer duration on the SkeletionUI.
Go to any chat where you have an existing IOU (Money Requests)
Verify that the skeleton view is showed for the money preview.
Once the transaction is loaded, it shows the amount, and description.
Repeat steps 3 to 5 for any distance requests. It should show skeleton view below the map.
Verify the skeleton view, looks like the following:

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Distance Requests

web-iou-skeleton-ui-3.mov

Multiple Requests

web-iou-skeleton-ui-2.mov

IOU Requests

web-iou-skeleton-ui-1.mov

Mobile Web - Chrome

mweb-chrome-ioi-skeleton-ui.mov

Mobile Web - Safari

mweb-safari-iou-skeleton-ui.mov

Desktop

desktop-iou-skeleton-ui.mov

iOS

ios-iou-skeleton-ui.mov

Android

android-iou-skeleton-ui.mov

hayata-suenaga · 2023-09-03T19:01:56Z

@mananjadhav Is it possible that you can push the rest of the changes soon? I think we want to fix this as soon as possible 🙇 (i.e. we want to deploy this to production)

mananjadhav · 2023-09-03T19:03:20Z

I am just working on the checklist.

melvin-bot · 2023-09-03T19:32:06Z

@shawnborton @fedirjh @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-09-03T19:32:31Z

@hayata-suenaga @mountiny @shawnborton @fedirjh The PR is ready.

mountiny · 2023-09-03T19:37:56Z

niiice, videos looking good!

mananjadhav · 2023-09-03T19:47:01Z

@parasharrajat I've fixed the comments. Should've raised a PR fresh in the morning to avoid silly changes. Thanks for catching those.

parasharrajat · 2023-09-03T20:29:51Z

@mananjadhav Can you please fix the attachments on the descriptions? It seems some are not rendered. We can work on it in the IST zone in the morning to if there are more requests.

mananjadhav · 2023-09-03T20:31:32Z

@parasharrajat I've updated the description so that Web attachments show up.

We can work on it in the IST zone in the morning to if there are more requests.

Sure that'll be great!

parasharrajat · 2023-09-03T20:47:07Z

I am seeing something strange. On every Money Report(iOU, Expense), it first shows a bottom skeleton loader and then it will be replaced with normal messages as well IOU preview.

Is this correct?

Check video from 0.15 Sec.

Screen.Recording.2023-09-04.at.2.16.27.AM.mov

mananjadhav · 2023-09-04T02:21:18Z

Yeah I thought so too. I am only replacing with the skeleton view, the behavior exists for other wise IOU requests too. I don't have the message context too that I can replace the message with any other skeleton view.

Check from 00:13 secs.

iou-shifting-action-item.mov

mountiny · 2023-09-04T05:24:34Z

Yeah I think the last thing is fine

parasharrajat · 2023-09-04T05:35:01Z

I see. In that case, it is fine.

parasharrajat · 2023-09-04T06:48:54Z

@mananjadhav What about ReportPreview component? I don't know where it is rendered exactly but this seems like a target too.

mountiny · 2023-09-04T13:34:07Z

@mananjadhav typescript and jest tests are failing

mountiny · 2023-09-04T13:34:23Z

Lets address those and the whisper hover and we can ship it

mananjadhav · 2023-09-04T13:37:31Z

@mountiny I am fixing the whisper style, but the actions seem to be unrelated to the change.

Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_c7bd8373-bd25-4ab3-b03b-381b3f466a98/d821e6bc-5da4-4209-8fc4-21fe9c41257f.tar.gz. return code: 2.

mananjadhav · 2023-09-04T14:00:40Z

@rezkiy37 Thanks for reporting the issue, but for some reason I am not able to reproduce this issue at my end. Can you tell me the reproduction steps?

web-whisper-hover-style.mov

rezkiy37 · 2023-09-04T14:04:00Z

@rezkiy37 Thanks for reporting the issue, but for some reason I am not able to reproduce this issue at my end. Can you tell me the reproduction steps?

web-whisper-hover-style.mov

Yeah, I see. Let try one more time, maybe someone has fixed it right now 😅

mananjadhav · 2023-09-04T14:04:06Z

Checking lint issues and other fixes.

rezkiy37 · 2023-09-04T14:06:43Z

Hah, it was fixed in another PR that was merged 3 hours ago. No bug anymore 🙂

mountiny · 2023-09-04T14:08:54Z

vit-26503theft to the rescue

mananjadhav · 2023-09-04T14:12:03Z

@mountiny @parasharrajat @rezkiy37 do we have any more outstanding comments?

rezkiy37 · 2023-09-04T14:13:14Z

@mountiny @parasharrajat @rezkiy37 do we have any more outstanding comments?

From my side, LGTM!

parasharrajat · 2023-09-04T14:18:15Z

Will do the checklist in 20 minutes.

parasharrajat · 2023-09-04T14:32:20Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-09-04.at.8.41.54.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-09-04.at.8.34.58.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-09-04.at.8.43.40.PM.mov

Screen.Recording.2023-09-04.at.8.44.42.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-09-04.at.8.22.24.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-09-04.at.8.39.28.PM.mov

🔲 Android / native

Screen.Recording.2023-09-04.at.8.32.07.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

mountiny

Thanks for all the hard work!

OSBotify · 2023-09-04T15:51:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-04T16:49:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T18:41:54Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:12:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:54:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

0xmiroslav · 2023-10-09T12:15:55Z

-                                        />
-                                        <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>{getSettledMessage()}</Text>
-                                    </>
+                    {_.isEmpty(props.transaction) ? (


This caused regression of showing skeleton forever when delete money request offline - #26939
Because transaction data is also deleted optimistically.

rushatgabhane · 2023-11-29T06:26:00Z

+                                                src={Expensicons.DotIndicator}
+                                                width={4}
+                                                height={4}
+                                                additionalStyles={[styles.mr1, styles.ml1]}


Coming from Dot separator in the report preview component appears bottom aligned
#29543

styles.mb1 isn't passed to Icon.

mananjadhav added 5 commits September 3, 2023 21:49

feat: basic skeletal view added

c251101

fix: update the lenght of the skeleton view

b2912b2

style: lint fixes

6c6e69d

refactor: rename the skeleton view file

c237268

style: lint fixes

230b2cc

hayata-suenaga self-requested a review September 3, 2023 19:01

mananjadhav marked this pull request as ready for review September 3, 2023 19:32

mananjadhav requested a review from a team as a code owner September 3, 2023 19:32

melvin-bot Bot requested review from fedirjh, mountiny and shawnborton and removed request for a team September 3, 2023 19:32

mountiny assigned mananjadhav Sep 3, 2023

parasharrajat suggested changes Sep 3, 2023

View reviewed changes

mananjadhav added 2 commits September 4, 2023 01:13

fix: pr comments

ad392c3

fix: remove props

166c12d

mananjadhav requested a review from parasharrajat September 3, 2023 19:47

style: lint fixes

aae804d

rezkiy37 approved these changes Sep 4, 2023

View reviewed changes

parasharrajat approved these changes Sep 4, 2023

View reviewed changes

mountiny approved these changes Sep 4, 2023

View reviewed changes

mountiny merged commit 41ca24b into Expensify:main Sep 4, 2023

OSBotify mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-04 #26686

Closed

35 tasks

lanitochka17 mentioned this pull request Sep 5, 2023

IOUs - Only one of the IOUs appear when IOU thread with multiple IOUs is loading #26764

Closed

6 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

melvin-bot Bot mentioned this pull request Sep 5, 2023

[HOLD for payment 2023-09-12] Add skeleton UI to requests and IOU / expense reports to avoid initially loading as $0.00 #26270

Closed

0xmiroslav reviewed Oct 9, 2023

View reviewed changes

0xmiroslav mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-02] [$500] Web/Desktop - Request skeleton is shown grayed out instead the IOU details. #26939

Closed

6 tasks

rushatgabhane reviewed Nov 29, 2023

View reviewed changes

rushatgabhane mentioned this pull request Nov 29, 2023

[HOLD for payment 2023-11-20] [$125] Dot separator in the report preview component appears bottom aligned #29543

Closed

6 tasks

Conversation

mananjadhav commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

hayata-suenaga commented Sep 3, 2023

Uh oh!

mananjadhav commented Sep 3, 2023

Uh oh!

melvin-bot Bot commented Sep 3, 2023

Uh oh!

mananjadhav commented Sep 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mountiny commented Sep 3, 2023

Uh oh!

mananjadhav commented Sep 3, 2023

Uh oh!

parasharrajat commented Sep 3, 2023

Uh oh!

mananjadhav commented Sep 3, 2023

Uh oh!

parasharrajat commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Sep 4, 2023

Uh oh!

parasharrajat commented Sep 4, 2023

Uh oh!

parasharrajat commented Sep 4, 2023

Uh oh!

mountiny commented Sep 4, 2023

Uh oh!

mountiny commented Sep 4, 2023

Uh oh!

mananjadhav commented Sep 4, 2023

Uh oh!

mananjadhav commented Sep 4, 2023

Uh oh!

rezkiy37 commented Sep 4, 2023

Uh oh!

mananjadhav commented Sep 4, 2023

Uh oh!

rezkiy37 commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Sep 4, 2023

Uh oh!

mananjadhav commented Sep 4, 2023

Uh oh!

rezkiy37 commented Sep 4, 2023

Uh oh!

parasharrajat commented Sep 4, 2023

Uh oh!

parasharrajat commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

mananjadhav commented Sep 3, 2023 •

edited

Loading

parasharrajat commented Sep 3, 2023 •

edited

Loading

mananjadhav commented Sep 4, 2023 •

edited

Loading

rezkiy37 commented Sep 4, 2023 •

edited

Loading

parasharrajat commented Sep 4, 2023 •

edited

Loading

0xmiroslav Oct 9, 2023 •

edited

Loading