fix: use common function to display rate by samh-nl · Pull Request #27816 · Expensify/App

samh-nl · 2023-09-19T22:13:35Z

Details

The reimbursement rate was incorrectly displayed due to it being a floating point, which was not taken into account in one case (but was in others). For consistent, and correct, displaying of the rate, util functions have been created and applied everywhere.

Fixed Issues

$ #27107
PROPOSAL: #27107 (comment)

Tests

Go to Settings
Go to Workspaces
Press on a workspace
Go to Reimbursements
Press on the reimbursement rate
Enter '1.283' as the rate
Press Save
Verify the rate is correctly displayed as entered
Go back to the LHN
Click on the FAB
Press Request money
Go to the Distance tab
Select any route
Press Next
Select the workspace
Verify that the rate is written with 3 decimals (i.e. 1.283) in the 'Distance' section
Press the Request button
Open the request in the report
Verify that the rate is written with 3 decimals (i.e. 1.283) in the request

Verify that no errors appear in the JS console

Offline tests

Go to Settings
Go to Workspaces
Press on a workspace
Go to Reimbursements
Press on the reimbursement rate
Enter '1.283' as the rate
Press Save
Verify the rate is correctly displayed as entered

Note: Distance money requests are not available while offline.

QA Steps

Go to Settings
Go to Workspaces
Press on a workspace
Go to Reimbursements
Press on the reimbursement rate
Enter '1.283' as the rate
Press Save
Verify the rate is correctly displayed as entered
Go back to the LHN
Click on the FAB
Press Request money
Go to the Distance tab
Select any route
Press Next
Select the workspace
Verify that the rate is written with 3 decimals (i.e. 1.283) in the 'Distance' section
Press the Request button
Open the request in the report
Verify that the rate is written with 3 decimals (i.e. 1.283) in the request

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.Screen.Recording.2023-09-19.at.22.45.38.mov

Mobile Web - Chrome

mWeb.Chrome.Screen.Recording.2023-09-20.at.00.01.17.mov

Mobile Web - Safari

mWeb.Safari.Screen.Recording.2023-09-19.at.23.17.13.mov

Desktop

Desktop.Screen.Recording.2023-09-19.at.22.44.22.mov

iOS

Native.iOS.Screen.Recording.2023-09-19.at.22.58.28.mov

Android

Native.Android.Screen.Recording.2023-09-19.at.23.55.24.mov

melvin-bot · 2023-09-19T22:13:39Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

samh-nl · 2023-09-22T09:32:58Z

Bump

burczu · 2023-09-22T09:38:12Z

@samh-nl Sorry for the delay - I was dealing with an issue with building the app for Android. I'll review your PR today.

burczu · 2023-09-22T09:41:17Z

+    if (Number.isNaN(numValue)) {
+        return NaN;
+    }
+    return numValue.toFixed(3);


This 3 looks like a magic number - maybe it would be worth to extract it to CONST.js?

Sure, I have defined it as CONST.CUSTOM_UNITS.RATE_DECIMALS, please see the latest commit.

burczu · 2023-09-22T09:41:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

27816-web.mov

Mobile Web - Chrome

27816-web-chrome.mov

Mobile Web - Safari

27816-web-safari.mov

Desktop

27816-desktop.mov

iOS

27816-ios.mov

Android

27816-android.mov

burczu

Reviewed, tested and approved.

OSBotify · 2023-09-25T03:00:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-25T10:04:09Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:46:30Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: use common function to display rate

e3a47e4

samh-nl requested a review from a team as a code owner September 19, 2023 22:13

melvin-bot Bot removed the request for review from a team September 19, 2023 22:13

melvin-bot Bot requested a review from burczu September 19, 2023 22:13

samh-nl mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-10-05] [$500] [Distance] Some rates in the distance field have an excessive number of zeros added after the decimal point #27107

Closed

6 tasks

burczu reviewed Sep 22, 2023

View reviewed changes

refactor: added constant

2fc4738

burczu approved these changes Sep 24, 2023

View reviewed changes

melvin-bot Bot requested a review from luacmartins September 24, 2023 12:31

luacmartins approved these changes Sep 25, 2023

View reviewed changes

luacmartins merged commit 5b33d50 into Expensify:main Sep 25, 2023

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

burczu mentioned this pull request Oct 10, 2023

Modify MoneyRequestConfirmPage for Distance Request #25707

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use common function to display rate#27816

fix: use common function to display rate#27816
luacmartins merged 2 commits into
Expensify:mainfrom
samh-nl:fix/issue-27107

samh-nl commented Sep 19, 2023

Uh oh!

melvin-bot Bot commented Sep 19, 2023

Uh oh!

samh-nl commented Sep 22, 2023

Uh oh!

burczu commented Sep 22, 2023

Uh oh!

burczu Sep 22, 2023

Uh oh!

samh-nl Sep 22, 2023

Uh oh!

burczu commented Sep 22, 2023 •

edited

Loading

Uh oh!

burczu left a comment

Uh oh!

OSBotify commented Sep 25, 2023

Uh oh!

OSBotify commented Sep 25, 2023

Uh oh!

OSBotify commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

samh-nl commented Sep 19, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 19, 2023

Uh oh!

samh-nl commented Sep 22, 2023

Uh oh!

burczu commented Sep 22, 2023

Uh oh!

burczu Sep 22, 2023

Choose a reason for hiding this comment

Uh oh!

samh-nl Sep 22, 2023

Choose a reason for hiding this comment

Uh oh!

burczu commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

burczu left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 25, 2023

Uh oh!

OSBotify commented Sep 25, 2023

Uh oh!

OSBotify commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

burczu commented Sep 22, 2023 •

edited

Loading