[CP Staging] fix select workspace request money by namhihi237 · Pull Request #27868 · Expensify/App

namhihi237 · 2023-09-20T14:25:08Z

Details

Fixed Issues

$ #27864
PROPOSAL:

Tests

Click on the FAB icon and select request money option
Enter money and press the next button
Select Workspace chat, and verify that the app does not crash

Verify that no errors appear in the JS console

Offline tests

The same test

QA Steps

The same test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-20.at.23.05.07.mov

Mobile Web - Chrome

RPReplay_Final1695226581.MP4

Mobile Web - Safari

RPReplay_Final1695226270.MP4

Desktop

Screen.Recording.2023-09-20.at.23.07.18.mov

iOS

Android

s77rt · 2023-09-20T14:46:17Z

We need to fix the same bug for workspace selection

namhihi237 · 2023-09-20T15:48:06Z

@s77rt I fixed the search by name, we use search text like create a group chat.

namhihi237 · 2023-09-20T16:44:36Z

@s77rt I tested on Web, desktop, safari, and mweb. Currently, I have an issue with my laptop, and now I'm having problems when building on native Android and iOS. You can help test it.

s77rt · 2023-09-20T17:36:10Z

        }
-        if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
+        if (hasMatchedParticipant) {
            return '';
        }


What is this for?

I see an error for that, If we only search name something like "workpace" and select the ws. It's not email and phone

Can you please attach a screenshot? That may be considerable as a bug

s77rt · 2023-09-20T17:36:46Z

        searchTerm.trim(),
        maxParticipantsReached,
-        _.some(participants, (participant) => participant.login.toLowerCase().includes(searchTerm.trim().toLowerCase())),
+        _.some(participants, (participant) => participant.searchText && participant.searchText.toLowerCase().includes(searchTerm.trim().toLowerCase())),


Is there left any case where searchText won't be set?

I see a case, If we select a workspace and an account. then un select an account. and click workspace => the searchText will be null.

Any idea why the searchText is null in this case?

s77rt · 2023-09-20T17:38:59Z

Please mark this as ready for review so we can get this merged asap.

melvin-bot · 2023-09-20T17:39:50Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-09-20T18:38:30Z

@namhihi237 Can you please prioritize this as it's a deploy blocker

namhihi237 · 2023-09-20T18:40:50Z

Yes, I'm checking it why searchText null when choose the row selected before

namhihi237 · 2023-09-20T18:51:19Z

@s77rt Please help to check.

s77rt · 2023-09-20T18:54:48Z

#27868 (comment)

namhihi237 · 2023-09-20T19:01:49Z

@s77rt Sorry, I sent the video and comment above but for some reason it's not public, it's pending status

Before

Screen.Recording.2023-09-21.at.01.14.09.mov

After changed

Screen.Recording.2023-09-21.at.01.15.31.mov

s77rt · 2023-09-20T19:03:46Z

I don't think that's necessary a bug, the search text is partial here, I think it's okay to revert that change

namhihi237 · 2023-09-20T19:07:38Z

Updated

s77rt · 2023-09-20T19:14:32Z

The bug occurs even if the exact name is typed

namhihi237 · 2023-09-20T19:17:47Z

Yes, In the above case I mentioned, the search does not email or phone.

namhihi237 · 2023-09-20T19:20:52Z

It will be shown as not found because of the condition bypass this case:

App/src/libs/OptionsListUtils.js

Lines 1437 to 1441 in 94c07ea

    
               if (hasMatchedParticipant && (isValidEmail || isValidPhone)) { 
        
                   return ''; 
        
               } 
        
               return Localize.translate(preferredLocale, 'common.noResultsFound'); 
        
           }

s77rt · 2023-09-20T19:24:22Z

I see, I don't think this is a blocker then

namhihi237 · 2023-09-20T19:28:07Z

So we'll continue like this and it will be fixed in another one?

s77rt · 2023-09-20T20:01:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny

Jumping in to get this CPed sooner than later

OSBotify · 2023-09-21T02:14:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] fix select workspace request money (cherry picked from commit e7bcd7f)

OSBotify · 2023-09-21T03:09:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.72-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-09-22T13:24:49Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:08:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:50:27Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix select workspace request money

d01e567

fix search by name

ef7190a

fix check search text in case select request money

7148c84

s77rt suggested changes Sep 20, 2023

View reviewed changes

namhihi237 marked this pull request as ready for review September 20, 2023 17:39

namhihi237 requested a review from a team as a code owner September 20, 2023 17:39

melvin-bot Bot requested review from s77rt and removed request for a team September 20, 2023 17:39

fix add get searchText

a1c10b3

revert search

586e997

s77rt approved these changes Sep 20, 2023

View reviewed changes

melvin-bot Bot requested a review from nkuoch September 20, 2023 20:01

mountiny assigned namhihi237 Sep 21, 2023

mountiny changed the title ~~fix select workspace request money~~ [CP Staging] fix select workspace request money Sep 21, 2023

mountiny approved these changes Sep 21, 2023

View reviewed changes

mountiny merged commit e7bcd7f into Expensify:main Sep 21, 2023

OSBotify pushed a commit that referenced this pull request Sep 21, 2023

Merge pull request #27868 from namhihi237/fix-select-workspace

e50fb7a

[CP Staging] fix select workspace request money (cherry picked from commit e7bcd7f)

OSBotify mentioned this pull request Sep 21, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

kavimuru mentioned this pull request Sep 21, 2023

web - Request money - 'Invalid source' message in the console when requesting money #27959

Closed

6 tasks

melvin-bot Bot mentioned this pull request Sep 22, 2023

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Web - App crash on request money with Workspace chat #27864

Closed

6 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

Conversation

namhihi237 commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

namhihi237 Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

namhihi237 Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

melvin-bot Bot commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Uh oh!

namhihi237 commented Sep 20, 2023

Uh oh!

s77rt commented Sep 20, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 21, 2023

Uh oh!

OSBotify commented Sep 21, 2023

Uh oh!

OSBotify commented Sep 22, 2023

Uh oh!

OSBotify commented Sep 25, 2023

Uh oh!

OSBotify commented Sep 28, 2023

Uh oh!

namhihi237 commented Sep 20, 2023 •

edited

Loading