Skip to content

[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view"#28929

Merged
srikarparsi merged 1 commit into
mainfrom
revert-28218-task-28048
Oct 5, 2023
Merged

[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view"#28929
srikarparsi merged 1 commit into
mainfrom
revert-28218-task-28048

Conversation

@mountiny

@mountiny mountiny commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Staright Revert #28218

Fixes a deploy blocker where room name is changed to participant names list https://expensify.slack.com/archives/C01GTK53T8Q/p1696510155669379

#28930

@mountiny mountiny self-assigned this Oct 5, 2023
@mountiny mountiny requested a review from a team as a code owner October 5, 2023 16:02
@melvin-bot melvin-bot Bot requested review from srikarparsi and removed request for a team October 5, 2023 16:03
@melvin-bot

melvin-bot Bot commented Oct 5, 2023

Copy link
Copy Markdown

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f493422
Status: ✅  Deploy successful!
Preview URL: https://ffb94821.helpdot.pages.dev
Branch Preview URL: https://revert-28218-task-28048.helpdot.pages.dev

View logs

@mountiny

mountiny commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

main, staging:
image

After revert
image

@srikarparsi srikarparsi merged commit 9d4e3bd into main Oct 5, 2023
@srikarparsi srikarparsi deleted the revert-28218-task-28048 branch October 5, 2023 16:41
@melvin-bot melvin-bot Bot added the Emergency label Oct 5, 2023
@melvin-bot

melvin-bot Bot commented Oct 5, 2023

Copy link
Copy Markdown

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@srikarparsi

Copy link
Copy Markdown
Contributor

straight revert, removing emergency

@OSBotify

OSBotify commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 5, 2023
[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view"

(cherry picked from commit 9d4e3bd)
@OSBotify

OSBotify commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.78-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants