Allow assigning task to new accounts by thienlnam · Pull Request #29730 · Expensify/App

thienlnam · 2023-10-16T23:05:05Z

Details

Changes made in this PR

Navigate back to parent report when there are no comments and a task is deleted
Updates 'Cancel' to 'Delete'
Allow optimistic assignees

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/311912
$ #33236
PROPOSAL:

Tests

Same as QA steps

Offline tests

Same as online

QA Steps

Assigning new user

Assign a task to a user that does not exist yet or someone you have not chatted with yet
Verify the task is created successfully
Reassign the task to another user that does not exist yet or someone you have not chatted with yet
Verify that the task is reassigned successfully and a 1:1 DM is created between you and the assignee

Navigation

Create a task
Delete the task. Ensure that you are redirected to the parent where the task was created and the task is gone
Create another task
Add a comment within that task
Delete the task. Verify that you are NOT redirected to the parent

PR Author Checklist

Screenshots/Videos

Android: Native

My IOS / Android simulators are not working so will have to have the C+ test those - but these changes are not platform specific by any means

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-12-21.at.2.28.29.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-21.at.2.27.12.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-21.at.2.33.52.PM.mov

melvin-bot · 2023-12-21T22:47:18Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-12-21T22:47:27Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2023-12-22T02:40:15Z

When I delete a task with no messages in it, it goes to parent chat but it does not show the [Deleted Task] message like it does in your Mac Chrome video.

Screen.Recording.2023-12-22.at.7.43.22.AM.mov

If there are messages like 'mark as complete' or 'mark as incomplete' in the task page it does not redirect to the parent chat when we delete the task. Just want to confirm if this is expected behaviour because these are system generated messages unlike user sent messages.

Screen.Recording.2023-12-22.at.7.31.08.AM.mov

Even though the task is completely deleted with no messages in it LHN still shows the [Deleted Message] report. Is this expected? If not is this within scope of this issue?

thienlnam · 2023-12-22T17:46:28Z

When I delete a task with no messages in it, it goes to parent chat but it does not show the [Deleted Task] message like it does in your Mac Chrome video.

Yup, that is correct - I think I had a weird issue in my chrome video

If there are messages like 'mark as complete' or 'mark as incomplete' in the task page it does not redirect to the parent chat when we delete the task. Just want to confirm if this is expected behaviour because these are system generated messages unlike user sent messages.

This is not intended, I updated the method to make sure this behavior does not happen

Even though the task is completely deleted with no messages in it LHN still shows the [Deleted Message] report. Is this expected? If not is this within scope of this issue?

Not intended but outside the scope of this issue

c3024 · 2023-12-22T18:40:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

assignTaskAndroidNative.mp4

Android: mWeb Chrome

assignTask.mp4

iOS: Native

Screen.Recording.2023-12-23.at.9.57.54.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-23.at.10.42.41.AM.mov

MacOS: Chrome / Safari

Assigning new user

Screen.Recording.2023-12-23.at.12.23.35.AM.mov

Navigating to parent report

Screen.Recording.2023-12-23.at.12.24.31.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-23.at.12.27.51.AM.mov

c3024

LGTM

melvin-bot · 2023-12-23T05:55:12Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-12-23T05:55:15Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #33536.

rlinoz · 2023-12-26T20:43:11Z

The code looks good!

Let me ask you, should we sill show [Deleted task] in the parent chat for tasks that have no comments, only changelogs?

thienlnam · 2024-01-02T19:29:34Z

Let me ask you, should we sill show [Deleted task] in the parent chat for tasks that have no comments, only changelogs?

No, if there are only change logs it should delete the task. However, the only system messages that should be able to exist in a task are related to task system messages

OSBotify · 2024-01-03T14:17:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-04T19:02:45Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:10:22Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-09T05:19:02Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2024-02-10T20:45:08Z

Delete task is destructive we missed to get a confirmation before delete, we handled it here

allow new accounts

48fb202

thienlnam changed the title ~~Allow assigning task to new accounts~~ [HOLD Web-E #39248]Allow assigning task to new accounts Oct 16, 2023

thienlnam added 2 commits December 20, 2023 14:51

Merge branch 'main' into jack-allowNewAssigneeTask

e315dab

Update cancel to delete

7c84211

thienlnam changed the title ~~[HOLD Web-E #39248]Allow assigning task to new accounts~~ [HOLD Auth #9509]Allow assigning task to new accounts Dec 20, 2023

thienlnam mentioned this pull request Dec 21, 2023

[$500] Chat - Two messages are displayed after deleting a task #33058

Closed

6 tasks

thienlnam self-assigned this Dec 21, 2023

thienlnam added 3 commits December 21, 2023 11:54

Merge branch 'main' into jack-allowNewAssigneeTask

a093d62

Redirect to parent report if the task should be deleted

cad48f1

Update Task.js

819fe34

thienlnam changed the title ~~[HOLD Auth #9509]Allow assigning task to new accounts~~ Allow assigning task to new accounts Dec 21, 2023

thienlnam marked this pull request as ready for review December 21, 2023 22:47

thienlnam requested a review from a team as a code owner December 21, 2023 22:47

melvin-bot Bot removed the request for review from a team December 21, 2023 22:47

melvin-bot Bot requested a review from c3024 December 21, 2023 22:47

thienlnam requested review from a team and removed request for c3024 December 21, 2023 22:47

melvin-bot Bot requested review from c3024 and removed request for a team December 21, 2023 22:47

c3024 reviewed Dec 22, 2023

View reviewed changes

Comment thread src/pages/home/HeaderView.js Outdated

Comment thread src/libs/actions/Task.js Outdated

Review comments / add new method to determine when to delete

c04a5da

Update comment

3461f6b

thienlnam requested a review from c3024 December 22, 2023 17:47

c3024 approved these changes Dec 23, 2023

View reviewed changes

melvin-bot Bot requested a review from rlinoz December 23, 2023 05:55

melvin-bot Bot mentioned this pull request Dec 23, 2023

Payment issue for E/App PR#29730 #33536

Closed

rlinoz approved these changes Jan 3, 2024

View reviewed changes

rlinoz merged commit fb0b1d1 into main Jan 3, 2024

rlinoz deleted the jack-allowNewAssigneeTask branch January 3, 2024 14:13

github-actions Bot mentioned this pull request Jan 4, 2024

Deploy Checklist: New Expensify 2024-01-04 #33973

Closed

74 tasks

Santhosh-Sellavel mentioned this pull request Feb 10, 2024

[HOLD for payment 2024-02-07] Confirmation popover missing for Cancel Task #35035

Closed

6 tasks

Conversation

thienlnam commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 21, 2023

Uh oh!

melvin-bot Bot commented Dec 21, 2023

Uh oh!

Uh oh!

Uh oh!

c3024 commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam commented Dec 22, 2023

Uh oh!

c3024 commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Dec 23, 2023

Uh oh!

melvin-bot Bot commented Dec 23, 2023

Uh oh!

rlinoz commented Dec 26, 2023

Uh oh!

thienlnam commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 3, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 9, 2024

Uh oh!

Santhosh-Sellavel commented Feb 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thienlnam commented Oct 16, 2023 •

edited

Loading

c3024 commented Dec 22, 2023 •

edited

Loading

c3024 commented Dec 22, 2023 •

edited

Loading