Resolve Cursor Position Issue on Long-Press in Android Chrome by ygshbht · Pull Request #30082 · Expensify/App

ygshbht · 2023-10-20T13:29:09Z

Details

This PR aims to solve an issue where long-pressing the back button in Android Chrome removes the last digit but moves the cursor ahead two positions instead of one. This occurrs because setCurrentAmount contains another setState, making it impure and error-prone. Various solutions were suggested, including merging currentAmount and selection; however, this solution introducing the hasSelectionBeenSet flag was chosen for its simplicity and lower risk of future errors #23300 (comment).

Fixed Issues

$ #23300
PROPOSAL: #23300 (comment)

Tests

Click FAB on Chrome mobile
Click Reqeust Money/ Split Bill
Enter amount more than 3 digits (e.g 6323)
Hold the back key "<"
Verify that last digit is removed and cursor is still at last place

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

XRecorder_20102023_193451.mp4

Android: mWeb Chrome

XRecorder_20102023_185626.mp4

iOS: Native

2023-10-20.19-41-18.mp4

iOS: mWeb Safari

2023-10-20.19-37-52.mp4

MacOS: Chrome / Safari

2023-10-20.19-07-29.mp4

MacOS: Desktop

2023-10-20.19-44-51.mp4

melvin-bot · 2023-10-20T13:29:15Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-10-20T18:39:28Z

-                setSelection((prevSelection) => getNewSelection(prevSelection, isForwardDelete ? strippedAmount.length : prevAmount.length, strippedAmount.length));
+                if (!hasSelectionBeenSet) {
+                    setSelection((prevSelection) => {
+                        hasSelectionBeenSet = true;


any reason to set it inside the setSelection, wouldn't having it after the if statement more meaningful?

Yes that makes more sense. That's what I had intially tried but saw some issues. I don't see those now, so i have moved the hasSelectionBeenSet out of setSelection

abdulrahuman5196 · 2023-10-20T18:39:31Z

                setFormError('');
            }
+
+            // There was an issue where long-pressing the back button in Android Chrome removed the last digit but moved the cursor ahead two positions instead of one. This occurred because setCurrentAmount contains another setState, making it impure and error-prone. Various solutions were suggested, including merging currentAmount and selection; however, this solution introducing the hasSelectionBeenSet flag was chosen for its simplicity and lower risk of future errors https://github.com/Expensify/App/issues/23300.


This is super long. Can we make it short and crisp and link the GH comment..

abdulrahuman5196 · 2023-10-20T18:40:17Z

@ygshbht Kindly check on these minor comments and kindly do add details of PR in the PR details section

ygshbht · 2023-10-20T19:23:49Z

@abdulrahuman5196 Done

ygshbht · 2023-10-22T12:53:10Z

@abdulrahuman5196 Let's try to get this closed within 3 days!

abdulrahuman5196

@ygshbht Kindly update this

abdulrahuman5196 · 2023-10-23T10:27:55Z

Reviewing now

abdulrahuman5196 · 2023-10-23T10:51:51Z

@ygshbht I am seeing this issue where if i place the cursor in between the digits and press back button it still deletes the last digit. Same goes for long press as well. The same is not happening in staging.

az_recorder_20231023_161907.mp4

Co-authored-by: abdulrahuman5196 <46707890+abdulrahuman5196@users.noreply.github.com>

ygshbht · 2023-10-23T12:26:34Z

@abdulrahuman5196 Isn't this the same issue that koko #23300 (comment) mentioned and you too previously? Apart from this issue (where you long press back button and then the curson position is not updated), I don't see any other issue. It's there is staging too. Can you please check if you are testing with the latest code and retest in staging?

abdulrahuman5196 · 2023-10-23T12:34:31Z

@abdulrahuman5196 Isn't this the same issue that koko #23300 (comment) mentioned and you too previously? Apart from this issue (where you long press back button and then the curson position is not updated), I don't see any other issue. It's there is staging too. Can you please check if you are testing with the latest code and retest in staging?

Yes. I did test with the latest code in this PR and with staging. Staging the issue is not occuring and in this PR the issue is occuring.

@ygshbht Could you check again and provide videos if you are able to repro that issue in staging?

ygshbht · 2023-10-23T12:45:11Z

@abdulrahuman5196 Staging video

XRecorder_23102023_181107.mp4

abdulrahuman5196 · 2023-10-24T10:06:21Z

Got it. This issue seems to be present in staging as well.

abdulrahuman5196 · 2023-10-24T10:38:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-24.at.3.38.17.PM.mp4

Mobile Web - Chrome

az_recorder_20231024_154156.mp4

Mobile Web - Safari

Screen.Recording.2023-10-24.at.3.48.10.PM.mp4

Desktop

Screen.Recording.2023-10-24.at.4.02.44.PM.mp4

iOS

Screen.Recording.2023-10-24.at.3.52.19.PM.mp4

Android

Screen.Recording.2023-10-24.at.3.58.47.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @madmax330

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2023-10-25T12:15:00Z

Gentle ping @madmax330

OSBotify · 2023-10-25T14:21:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-25T16:59:32Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:41:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Resolve Cursor Position Issue on Long-Press in Android Chrome

cfb9541

ygshbht requested a review from a team as a code owner October 20, 2023 13:29

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team October 20, 2023 13:29

ygshbht mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-11-02] [$2000] IOU : Inconsistent behavior when long pressing the back button in Android app vs mWeb #23300

Closed

6 tasks

abdulrahuman5196 reviewed Oct 20, 2023

View reviewed changes

ygshbht added 2 commits October 21, 2023 00:49

Refactor MoneyRequestAmountForm setNewAmount

0289c38

Comment update

f9e41e1

abdulrahuman5196 suggested changes Oct 23, 2023

View reviewed changes

Comment thread src/pages/iou/steps/MoneyRequestAmountForm.js Outdated

Update comment src/pages/iou/steps/MoneyRequestAmountForm.js

4bae23f

Co-authored-by: abdulrahuman5196 <46707890+abdulrahuman5196@users.noreply.github.com>

abdulrahuman5196 approved these changes Oct 24, 2023

View reviewed changes

melvin-bot Bot requested a review from madmax330 October 24, 2023 10:43

madmax330 approved these changes Oct 25, 2023

View reviewed changes

madmax330 merged commit 2d6e8ef into Expensify:main Oct 25, 2023

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

shubham1206agra mentioned this pull request Feb 3, 2024

Fix Workspace Rate Unit Form Flow #34849

Merged

49 tasks

Conversation

ygshbht commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 20, 2023

Uh oh!

abdulrahuman5196 Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

ygshbht Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 20, 2023

Uh oh!

ygshbht commented Oct 20, 2023

Uh oh!

ygshbht commented Oct 22, 2023

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abdulrahuman5196 commented Oct 23, 2023

Uh oh!

abdulrahuman5196 commented Oct 23, 2023

Uh oh!

ygshbht commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ygshbht commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Oct 24, 2023

Uh oh!

abdulrahuman5196 commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ygshbht commented Oct 20, 2023 •

edited

Loading

ygshbht commented Oct 23, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 23, 2023 •

edited

Loading

ygshbht commented Oct 23, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 24, 2023 •

edited

Loading