-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[TS Migration] Migrate 'FormHelpMessage.js' component to TypeScript #30487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MariaHCD
merged 11 commits into
Expensify:main
from
pasyukevich:feature/migrate-FormHelpMessage
Dec 11, 2023
+51
−63
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d5f1f41
Migrate 'FormHelpMessage.js' component to TypeScript
pasyukevich 806d75e
Merge branch 'main' into feature/migrate-FormHelpMessage
pasyukevich 1eb479a
update imports
pasyukevich 007a6bc
remove array for style prop
pasyukevich 27cded2
replace lodash isEmpty with helper
pasyukevich 55556f7
Merge branch 'main' into feature/migrate-FormHelpMessage
pasyukevich abe189c
update type using
pasyukevich ef02aac
Merge branch 'main' into feature/migrate-FormHelpMessage
pasyukevich de60770
revert isEmpty replacement
pasyukevich 8bafbbf
Merge branch 'main' into feature/migrate-FormHelpMessage
pasyukevich 2bfa28d
update error type to use Localize
pasyukevich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import isEmpty from 'lodash/isEmpty'; | ||
| import React from 'react'; | ||
| import {StyleProp, View, ViewStyle} from 'react-native'; | ||
| import * as Localize from '@libs/Localize'; | ||
| import useTheme from '@styles/themes/useTheme'; | ||
| import useThemeStyles from '@styles/useThemeStyles'; | ||
| import Icon from './Icon'; | ||
| import * as Expensicons from './Icon/Expensicons'; | ||
| import Text from './Text'; | ||
|
|
||
| type FormHelpMessageProps = { | ||
| /** Error or hint text. Ignored when children is not empty */ | ||
| message?: Localize.MaybePhraseKey; | ||
|
|
||
| /** Children to render next to dot indicator */ | ||
| children?: React.ReactNode; | ||
|
|
||
| /** Indicates whether to show error or hint */ | ||
| isError?: boolean; | ||
|
|
||
| /** Container style props */ | ||
| style?: StyleProp<ViewStyle>; | ||
| }; | ||
|
|
||
| function FormHelpMessage({message = '', children, isError = true, style}: FormHelpMessageProps) { | ||
| const theme = useTheme(); | ||
| const styles = useThemeStyles(); | ||
| if (isEmpty(message) && isEmpty(children)) { | ||
| return null; | ||
| } | ||
|
|
||
| const translatedMessage = Localize.translateIfPhraseKey(message); | ||
|
pasyukevich marked this conversation as resolved.
|
||
|
|
||
| return ( | ||
| <View style={[styles.flexRow, styles.alignItemsCenter, styles.mt2, styles.mb1, style]}> | ||
| {isError && ( | ||
| <Icon | ||
| src={Expensicons.DotIndicator} | ||
| fill={theme.danger} | ||
| /> | ||
| )} | ||
| <View style={[styles.flex1, isError && styles.ml2]}>{children ?? <Text style={[isError ? styles.formError : styles.formHelp, styles.mb0]}>{translatedMessage}</Text>}</View> | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| FormHelpMessage.displayName = 'FormHelpMessage'; | ||
|
|
||
| export default FormHelpMessage; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.