Skip to content

Add a new template for requesting a library to be added in package.json#31035

Merged
grgia merged 3 commits into
mainfrom
tgolen-library-review-template
Nov 9, 2023
Merged

Add a new template for requesting a library to be added in package.json#31035
grgia merged 3 commits into
mainfrom
tgolen-library-review-template

Conversation

@tgolen

@tgolen tgolen commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/334255

Tests

None

Offline tests

None

QA Steps

None

PR Author Checklist

No checklist required for this change since it's only adding a GH issue template

@tgolen tgolen self-assigned this Nov 7, 2023
@tgolen tgolen requested a review from a team as a code owner November 7, 2023 21:41
@tgolen

tgolen commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

cc @AndrewGable @mountiny

@melvin-bot melvin-bot Bot requested review from grgia and removed request for a team November 7, 2023 21:41
@melvin-bot

melvin-bot Bot commented Nov 7, 2023

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny

mountiny commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Copy looks good to me, @grgia all yours!

@tgolen

tgolen commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

The tests will fail on this PR due to not having any checklists. This is OK to bypass and merge since the changes do not change any code.

@tgolen

tgolen commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

bump @grgia for review please

@grgia grgia merged commit c3692a7 into main Nov 9, 2023
@grgia grgia deleted the tgolen-library-review-template branch November 9, 2023 17:32
@melvin-bot melvin-bot Bot added the Emergency label Nov 9, 2023
@melvin-bot

melvin-bot Bot commented Nov 9, 2023

Copy link
Copy Markdown

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@grgia grgia removed the Emergency label Nov 9, 2023
@grgia

grgia commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

#31035 (comment) ^

@OSBotify

OSBotify commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.98-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.99-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants