Fix not found page display briefly after deleting the workspace by dukenv0307 · Pull Request #31255 · Expensify/App

dukenv0307 · 2023-11-13T03:31:13Z

Details

Fix not found page display briefly after deleting the workspace

Fixed Issues

$ #30100
PROPOSAL: #30100 (comment)

Tests

Create a workspace
Go to the announce report
Click on the header
Click on the name of workspace to open workspace page
Click on three-dot icon > Delete workspace
Verify that not found page doesn't display briefly

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a workspace
Go to the announce report
Click on the header
Click on the name of workspace to open workspace page
Click on three-dot icon > Delete workspace
Verify that not found page doesn't display briefly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-13.at.10.20.18.mov

Android: mWeb Chrome

Screen.Recording.2023-11-13.at.10.12.38.mov

iOS: Native

Screen.Recording.2023-11-13.at.10.22.04.mov

iOS: mWeb Safari

Screen.Recording.2023-11-13.at.10.08.19.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-13.at.10.06.18.mov

MacOS: Desktop

Screen.Recording.2023-11-13.at.10.28.30.mov

melvin-bot · 2023-11-13T03:31:31Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-11-14T09:44:31Z

+
+    // We should check both policy and prevPolicy to prevent not found page appearing after we delete the workspace and navigate
+    // eslint-disable-next-line rulesdir/no-negated-variables
+    const shouldShowNotFoundPage = _.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy) || (PolicyUtils.isPendingDeletePolicy(policy) && PolicyUtils.isPendingDeletePolicy(prevPolicy));


Can you add more details to the comment or only put (PolicyUtils.isPendingDeletePolicy(policy) && PolicyUtils.isPendingDeletePolicy(prevPolicy)) in a variable and comment it? The current comment is confusing me, some people will ask why don't we check prevPolicy for _.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy)

@hoangzinh I updated.

hoangzinh

Overal looks good, just one small feedbac

Co-authored-by: Vinh Hoang <hoangzinhvn@gmail.com>

dukenv0307 · 2023-11-14T15:49:31Z

@hoangzinh Updated.

hoangzinh · 2023-11-14T15:54:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-14.at.23.29.17.mp4

Android: mWeb Chrome

Screen.Recording.2023-11-14.at.23.21.59.-.android.chrome.mov

iOS: Native

Screen.Recording.2023-11-14.at.23.03.02.-.ios.mp4

iOS: mWeb Safari

Screen.Recording.2023-11-14.at.23.16.41.-.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-14.at.23.00.36.-.web.mov

MacOS: Desktop

Screen.Recording.2023-11-14.at.23.24.25.-.desktop.mov

hoangzinh

LGTM

amyevans

Looks great!

OSBotify · 2023-11-14T17:03:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-14T22:08:55Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:52:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T21:07:33Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 3 commits October 23, 2023 09:49

fix: 30100

b068258

merge main

3038e7f

fix lint

3f98313

dukenv0307 marked this pull request as ready for review November 13, 2023 03:31

dukenv0307 requested a review from a team as a code owner November 13, 2023 03:31

melvin-bot Bot requested review from hoangzinh and removed request for a team November 13, 2023 03:31

hoangzinh reviewed Nov 13, 2023

View reviewed changes

Comment thread src/pages/workspace/WorkspaceInitialPage.js Outdated

dukenv0307 added 3 commits November 14, 2023 11:56

Merge branch 'main' into fix/30100

78fda3d

add variable

a532c04

fix lint

b6facd7

hoangzinh reviewed Nov 14, 2023

View reviewed changes

dukenv0307 added 2 commits November 14, 2023 17:04

edit comment

b311a90

edit comment

21d0e41

hoangzinh reviewed Nov 14, 2023

View reviewed changes

Comment thread src/pages/workspace/WorkspaceInitialPage.js Outdated

Update src/pages/workspace/WorkspaceInitialPage.js

c57dc10

Co-authored-by: Vinh Hoang <hoangzinhvn@gmail.com>

hoangzinh approved these changes Nov 14, 2023

View reviewed changes

melvin-bot Bot requested a review from amyevans November 14, 2023 16:31

amyevans approved these changes Nov 14, 2023

View reviewed changes

amyevans merged commit 183cce0 into Expensify:main Nov 14, 2023

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

OSBotify mentioned this pull request Nov 15, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

melvin-bot Bot mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-11-22] [$500] Workspace - Error page appears for a second after deleting a Workspace #30100

Closed

6 tasks

Conversation

dukenv0307 commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 13, 2023

Uh oh!

Uh oh!

hoangzinh Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dukenv0307 commented Nov 14, 2023

Uh oh!

hoangzinh commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

OSBotify commented Nov 15, 2023

Uh oh!

OSBotify commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Nov 13, 2023 •

edited

Loading

hoangzinh commented Nov 14, 2023 •

edited

Loading