Request Physical Card Follow Up by pac-guerreiro · Pull Request #31782 · Expensify/App

pac-guerreiro · 2023-11-23T12:30:05Z

Details

This PR fixes two issues reported by @allroundexperts while he was reviewing the Request Physical Card flow:

Expensify card page shows a "Not Found" state momentarily sometimes, because onyx props are still being loaded;
Back button not behaving correctly inside the Request Physical Card flow, because of page redirection if user tries to access the next step on the flow before finishing the current.

Fixed Issues

$ #31557
PROPOSAL:

Set cardList prop default value as null, create a new boolean state variable that holds the information if the Not Found component is shown or not, and only set this flag when the cardList is defined.
Instead of navigating to the expected page, just go back to the previous one.

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-27.at.20.47.44.mp4

Android: mWeb Chrome

Screen.Recording.2023-11-27.at.19.01.28.mp4

iOS: Native

Screen.Recording.2023-11-27.at.19.24.49.mp4

iOS: mWeb Safari

Screen.Recording.2023-11-27.at.19.29.29.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-11-27.at.16.19.03.mp4

MacOS: Desktop

Screen.Recording.2023-11-27.at.18.43.26.mp4

… immediately

…essary-routes

melvin-bot · 2023-11-23T12:30:11Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pac-guerreiro · 2023-11-23T12:32:19Z

@allroundexperts I'll add the screen recordings soon

…essary-routes

pac-guerreiro · 2023-11-27T16:22:34Z

@allroundexperts @grgia
Added Google Chrome screen recording showing both fixes. Working on the other screen recordings

pac-guerreiro · 2023-11-27T20:49:33Z

@allroundexperts @grgia
All screen recordings have been added!

…essary-routes

grgia · 2023-11-29T10:13:44Z

@allroundexperts could you prioritize this clean up PR today?

…essary-routes

allroundexperts · 2023-11-30T12:28:03Z

On it today @grgia

allroundexperts · 2023-12-03T22:17:54Z

@pac-guerreiro The following is still happening. Can you please check? Setting network mode to slow 3g might help you to debug this better.

Screen.Recording.2023-12-04.at.3.17.00.AM.mov

pac-guerreiro · 2023-12-04T22:32:47Z

@allroundexperts

Thanks for the tip, I finally understood what was the real problem you were showing me.

From my research, the root cause of the problem is setting the mock data using an useEffect because:

While we're fetching the cardList data from the API, the mock data is used so it allows us to click the card item from the list
When the API data comes, the mock data is erased, so the card page shows the not found state
Then the useEffect is triggered again and the mock data is set, thus showing the card page again

Besides, I noticed from your and mine network logs that each time we're entering the wallet page we're fetching the data from the API twice, which only aggravates this weird behaviour

allroundexperts · 2023-12-05T00:53:47Z

Hi @pac-guerreiro!
The following is not fixed as well:

Screen.Recording.2023-12-05.at.5.52.49.AM.mov

pac-guerreiro · 2023-12-05T16:12:13Z

@allroundexperts

That is caused by the mock data getting replaced with the data from the API. You can confirm this by manually inserting the mock data on chrome console, and then the empty page becomes the card page.

dylanexpensify · 2023-12-08T12:08:51Z

@allroundexperts can we get an update here please? 🙇‍♂️

allroundexperts · 2023-12-10T23:16:14Z

@pac-guerreiro If both of these issues are caused by setting mock data in the useEffect, then, I'm not sure what exactly are we fixing here?

pac-guerreiro · 2023-12-11T16:07:25Z

@allroundexperts regarding the two original issues, I guess only the first one occurs because of how the mock data is set. The second one regarding the back button behaviour is relevant.

CC: @grgia

grgia · 2023-12-11T17:06:04Z

@pac-guerreiro @allroundexperts
Could you summarize where we're at with this issue and if you have any questions or need clarification?

pac-guerreiro · 2023-12-12T18:12:17Z

@grgia

From the initial 2 issues that this PR aims to fix, the first one seems to be caused by how the mock data is set and shouldn't be reproducible in production, the second one is fixed.

grgia · 2023-12-14T23:57:01Z

@pac-guerreiro what does this PR aim to fix in that case?

pac-guerreiro · 2023-12-18T15:51:55Z

@grgia This PR aims to fix the second issue - Back button not behaving correctly inside the Request Physical Card flow, because of page redirection if user tries to access the next step on the flow before finishing the current.

allroundexperts · 2023-12-19T04:29:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-19.at.3.19.27.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-19.at.3.17.45.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-12-19.at.2.49.14.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-19.at.2.46.18.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-19.at.2.48.04.PM.mov

allroundexperts · 2023-12-19T14:17:58Z

Having issues with my iOS simulator. I've tested this on all platforms except native iOS. I think this change is not related to iOS in particular so I am approving the PR!

allroundexperts

Looks good!

grgia

LGTM!

grgia · 2023-12-19T18:11:18Z

Great work on this follow up @pac-guerreiro !

OSBotify · 2023-12-19T18:15:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:30:26Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-22T05:19:09Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

pac-guerreiro added 3 commits November 22, 2023 23:02

fix(expensify card page): not found state showing up and disappearing…

800d2b1

… immediately

Merge branch 'main' into feature/add-get-physical-card-button-and-nec…

889bd6d

…essary-routes

fix(get physical card): weird back button behaviour

bf79989

pac-guerreiro requested a review from a team as a code owner November 23, 2023 12:30

melvin-bot Bot requested review from allroundexperts and removed request for a team November 23, 2023 12:30

pac-guerreiro added 2 commits November 23, 2023 12:34

Merge branch 'main' into feature/add-get-physical-card-button-and-nec…

b69b20f

…essary-routes

Merge branch 'main' into feature/add-get-physical-card-button-and-nec…

2fdd353

…essary-routes

Merge branch 'main' into feature/add-get-physical-card-button-and-nec…

8f1dc74

…essary-routes

Merge branch 'main' into feature/add-get-physical-card-button-and-nec…

ca1b223

…essary-routes

allroundexperts approved these changes Dec 19, 2023

View reviewed changes

melvin-bot Bot requested a review from grgia December 19, 2023 14:18

grgia approved these changes Dec 19, 2023

View reviewed changes

grgia merged commit c0313c2 into Expensify:main Dec 19, 2023

github-actions Bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

melvin-bot Bot mentioned this pull request Dec 22, 2023

[HOLD for payment 2023-12-29] [ECARD] HIGH: Request Physical Card Follow Up #31557

Closed

Conversation

pac-guerreiro commented Nov 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 23, 2023

Uh oh!

pac-guerreiro commented Nov 23, 2023

Uh oh!

pac-guerreiro commented Nov 27, 2023

Uh oh!

pac-guerreiro commented Nov 27, 2023

Uh oh!

grgia commented Nov 29, 2023

Uh oh!

allroundexperts commented Nov 30, 2023

Uh oh!

allroundexperts commented Dec 3, 2023

Uh oh!

pac-guerreiro commented Dec 4, 2023

Uh oh!

allroundexperts commented Dec 5, 2023

Uh oh!

pac-guerreiro commented Dec 5, 2023

Uh oh!

dylanexpensify commented Dec 8, 2023

Uh oh!

allroundexperts commented Dec 10, 2023

Uh oh!

pac-guerreiro commented Dec 11, 2023

Uh oh!

grgia commented Dec 11, 2023

Uh oh!

pac-guerreiro commented Dec 12, 2023

Uh oh!

grgia commented Dec 14, 2023

Uh oh!

pac-guerreiro commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Dec 19, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Dec 19, 2023

Uh oh!

OSBotify commented Dec 19, 2023

Uh oh!

OSBotify commented Dec 21, 2023

Uh oh!

OSBotify commented Dec 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pac-guerreiro commented Nov 23, 2023 •

edited

Loading

pac-guerreiro commented Dec 18, 2023 •

edited

Loading

allroundexperts commented Dec 19, 2023 •

edited

Loading