-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[TS migration] Migrate 'BlockingViews' component to TypeScript #32253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joelbettner
merged 8 commits into
Expensify:main
from
software-mansion-labs:ts-migration/blocking-view
Dec 30, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2b40a50
migrate BlockingView and associated components to ts
cdOut 618b949
fix review suggestions
cdOut 0fe0448
remove files from another PR
cdOut 57bebf0
Merge branch 'main' into ts-migration/blocking-view
cdOut 53ce402
add review suggested changes
cdOut 2fffff7
Merge branch 'main' into ts-migration/blocking-view
cdOut d109836
Merge branch 'main' into ts-migration/blocking-view
cdOut ad34368
fix typescript errors
cdOut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 0 additions & 42 deletions
42
src/components/BlockingViews/FullPageOfflineBlockingView.js
This file was deleted.
Oops, something went wrong.
31 changes: 31 additions & 0 deletions
31
src/components/BlockingViews/FullPageOfflineBlockingView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import React from 'react'; | ||
| import * as Expensicons from '@components/Icon/Expensicons'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useNetwork from '@hooks/useNetwork'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import ChildrenProps from '@src/types/utils/ChildrenProps'; | ||
| import BlockingView from './BlockingView'; | ||
|
|
||
| function FullPageOfflineBlockingView({children}: ChildrenProps) { | ||
| const {translate} = useLocalize(); | ||
| const {isOffline} = useNetwork(); | ||
|
|
||
| const theme = useTheme(); | ||
|
|
||
| if (isOffline) { | ||
| return ( | ||
| <BlockingView | ||
| icon={Expensicons.OfflineCloud} | ||
| iconColor={theme.offline} | ||
| title={translate('common.youAppearToBeOffline')} | ||
| subtitle={translate('common.thisFeatureRequiresInternet')} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| return children; | ||
| } | ||
|
|
||
| FullPageOfflineBlockingView.displayName = 'FullPageOfflineBlockingView'; | ||
|
|
||
| export default FullPageOfflineBlockingView; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.