Skip to content

Status, theme fix #33333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 1 commit into from
Dec 20, 2023
Merged

Status, theme fix #33333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ function StatusClearAfterPage({currentUserPersonalDetails, customStatus}) {
key={`${index}+${item.value}`}
onSelectRow={() => updateMode(item)}
showTooltip={false}
isFocused={item.isSelected}

@rlinoz rlinoz Dec 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the SelectionList instead? As we do in the PriorityModePage?

@perunt perunt Dec 20, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SelectionList under the hood uses the same component as I did. SelectionList is a wrap that provides search input and other functionalities. So, the theme switching or style changes will also apply to it.

/>
)),
[statusType, updateMode],
Expand Down